Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ScottyMJacobson/snowplow-javascript-tracker
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: ptelad/snowplow-javascript-tracker
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 13 commits
  • 5 files changed
  • 3 contributors

Commits on Feb 5, 2019

  1. add eventMethod option 'beacon:text/plain', which uses navigator.send… 

    …Beacon but lies about the Content-Type and makes it `text/plain` to get around Chrome limitations
    Scotty Jacobson
    Scotty Jacobson committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    1c26978 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feature/beacon-plaintext

    Scotty Jacobson
    Scotty Jacobson committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    cec49ee View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2019

  1. During beforeunload, set bufferSize to 1, so that any events sent aft… 

    …erwards don't get buffered and are immediately sent
    Scotty Jacobson
    Scotty Jacobson committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    b566f16 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2019

  1. iOS workaround: listen to pagehide as well as beforeunload so tha… 

    …t we can flush our out queue on iOS (beforeunload doesn't seem to exist on iOS)
    Scotty Jacobson
    Scotty Jacobson committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    1e45c28 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2019

  1. Workaround attempt for iOS webviews' rejecting HTTPS beacon calls unl… 

    …ess an XHR request has been sent to that address
    Scotty Jacobson
    Scotty Jacobson committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    8bee92c View commit details
    Browse the repository at this point in the history

  2. package.json to allow building + importing with npm into (client-side… 

    …) lib
    Scotty Jacobson
    Scotty Jacobson committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    563330e View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2019

  1. fix bug (misnamed function) in unlockbeacon after 'visibilitychange' … 

    …callback
    Scotty Jacobson
    Scotty Jacobson committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    c43a70f View commit details
    Browse the repository at this point in the history

  2. iOS workaround: send a POST XHR request before _every_ sendBeacon call 

    this is more heavy-handed than we'd like and will pollute our bad-events stream; i'll tweak and find the exact times i need to make this request
    Scotty Jacobson
    Scotty Jacobson committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    233eb05 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2019

  1. use dist/snowplow.js as "main", instead of dist/bundle-postbabel.js. … 

    …this should fix EA-1, where the version was always js-<%= pkg.version %>
    Scotty Jacobson
    Scotty Jacobson committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    5e3046b View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2019

  1. force "postinstall" to also run "prepare" script 

    it looks like there is a bug in npm that sometimes doesn't run "prepare" when installing from a git repo, even though "prepare" should be run
https://npm.community/t/npm-lifecycle-scripts-such-as-prepare-not-run-when-install-from-git-repo/10253/2

if we force it to "prepare" on "postinstall" then we should be almost assured that "prepare" is always run
    Scotty Jacobson
    Scotty Jacobson committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    a37e965 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2019

  1. Merge branch 'feature/beacon-plaintext'

    Elad Gil
    Elad Gil committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    e5f388d View commit details
    Browse the repository at this point in the history

  2. Update package.json

    @ptelad
    ptelad authored Nov 25, 2019
    Configuration menu
    Copy the full SHA
    9d3c2f0 View commit details
    Browse the repository at this point in the history

  3. Update package.json

    @ptelad
    ptelad authored Nov 25, 2019
    Configuration menu
    Copy the full SHA
    e86a66e View commit details
    Browse the repository at this point in the history
Loading