Skip to content

Commit 05d0b30

Browse files
committed
Cast date format to UTC
1 parent cfc9bbe commit 05d0b30

File tree

7 files changed

+25
-33
lines changed

7 files changed

+25
-33
lines changed

src/scripts/activity.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class Activity {
4848
if (setting_restriction_list !== undefined && setting_restriction_list.length > 0) {
4949
var item = setting_restriction_list.find(o => isDomainEquals(o.domain, domain));
5050
if (item !== undefined) {
51-
var today = new Date().toLocaleDateString();
51+
var today = new Date().toLocaleDateString("en-US");
5252
var data = tab.days.find(x => x.date == today);
5353
if (data !== undefined) {
5454
var todayTimeUse = data.summary;

src/scripts/background.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ function mainTRacker(activeUrl, tab, activeTab) {
7272
});
7373
} else {
7474
chrome.browserAction.setBadgeBackgroundColor({ color: [0, 0, 0, 0] })
75-
var today = new Date().toLocaleDateString();
75+
var today = new Date().toLocaleDateString("en-US");
7676
var summary = tab.days.find(s => s.date === today).summary;
7777
chrome.browserAction.setBadgeText({
7878
tabId: activeTab.id,

src/scripts/chart/chart-core.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -252,23 +252,23 @@ function barChart(data) {
252252
.offset([-10, 0])
253253
.html(function (d) {
254254
if (data.length > 9)
255-
return "<strong><span class='red-label'>" + d.date + "</span></strong></br><strong>" + convertShortSummaryTimeToString(d.total) + "</strong>";
255+
return "<strong><span class='red-label'>" + new Date(d.date).toLocaleDateString() + "</span></strong></br><strong>" + convertShortSummaryTimeToString(d.total) + "</strong>";
256256
else
257257
return "<strong>" + convertShortSummaryTimeToString(d.total) + "</strong>";
258258
});
259259

260260
svg.call(tip);
261261

262262
// Scale the range of the data in the domains
263-
x.domain(data.map(function (d) { return d.date; }));
263+
x.domain(data.map(function (d) { return new Date(d.date).toLocaleDateString(); }));
264264
y.domain([0, d3.max(data, function (d) { return d.total; })]);
265265

266266
// append the rectangles for the bar chart
267267
svg.selectAll(".bar")
268268
.data(data)
269269
.enter().append("rect")
270270
.attr("class", "bar")
271-
.attr("x", function (d) { return x(d.date); })
271+
.attr("x", function (d) { return x(new Date(d.date).toLocaleDateString()); })
272272
.attr("width", x.bandwidth())
273273
.attr("y", function (d) { return y(d.total); })
274274
.attr("height", function (d) { return height - y(d.total); })

src/scripts/common.js

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -127,18 +127,11 @@ function zeroAppend(time) {
127127
}
128128

129129
function isDateInRange(dateStr, range) {
130-
return dateStr >= range.from && dateStr <= range.to;
130+
return new Date(dateStr) >= range.from && new Date(dateStr) <= range.to;
131131
}
132132

133-
function getDateValueFromString(value) {
134-
var arr;
135-
if (value.indexOf('.') !== -1) {
136-
arr = value.split('.');
137-
return new Date(arr[2], arr[1] - 1, arr[0]);
138-
}
139-
if (value.indexOf('/') !== -1)
140-
arr = value.split('/');
141-
return new Date(arr[2], arr[0] - 1, arr[1]);
133+
function isCorrectDate(range){
134+
return range.from.getFullYear() >= 2019 && range.to.getFullYear() >= 2019;
142135
}
143136

144137
function getDateFromRange(range) {

src/scripts/tab.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class Tab {
2121
incSummaryTime() {
2222
this.summaryTime += 1;
2323

24-
var today = new Date().toLocaleDateString();
24+
var today = new Date().toLocaleDateString("en-US");
2525
var day = this.days.find(x => x.date == today);
2626
if (day === undefined) {
2727
this.addNewDay(today);
@@ -34,7 +34,7 @@ class Tab {
3434
incCounter(){
3535
this.counter +=1;
3636

37-
var today = new Date().toLocaleDateString();
37+
var today = new Date().toLocaleDateString("en-US");
3838
var day = this.days.find(x => x.date == today);
3939
if (day === undefined) {
4040
this.addNewDay(today);

src/scripts/ui.js

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,9 @@ class UI {
104104
p.innerHTML = 'Today (' + counterOfSite + ' sites)';
105105
if (currentTypeOfList === TypeListEnum.All && totalDays !== undefined) {
106106
if (totalDays.countOfDays > 0) {
107-
p.innerHTML = 'Aggregate data since ' + totalDays.minDate + ' (' + totalDays.countOfDays + ' days) (' + counterOfSite + ' sites)';
107+
p.innerHTML = 'Aggregate data since ' + new Date(totalDays.minDate).toLocaleDateString() + ' (' + totalDays.countOfDays + ' days) (' + counterOfSite + ' sites)';
108108
} else {
109-
p.innerHTML = 'Aggregate data since ' + today + ' (' + counterOfSite + ' sites)';
109+
p.innerHTML = 'Aggregate data since ' + new Date().toLocaleDateString() + ' (' + counterOfSite + ' sites)';
110110
}
111111
}
112112

@@ -208,18 +208,17 @@ class UI {
208208
var from = this.createElement('span', null, 'From');
209209
var to = this.createElement('span', null,'To');
210210

211-
var dateNow = new Date();
212211
var calendarFirst = document.createElement('input');
213212
calendarFirst.id = 'dateFrom';
214213
calendarFirst.type = 'date';
215-
var previousDate = new Date(Date.UTC(dateNow.getFullYear(), dateNow.getMonth(), dateNow.getDate()));
214+
var previousDate = new Date();
216215
previousDate.setDate(previousDate.getDate() - getDateFromRange(range));
217-
calendarFirst.valueAsDate = previousDate;
216+
calendarFirst.valueAsDate = new Date(Date.UTC(previousDate.getFullYear(), previousDate.getMonth(), previousDate.getDate()));
218217

219218
var calendarTwo = document.createElement('input');
220219
calendarTwo.id = 'dateTo';
221220
calendarTwo.type = 'date';
222-
calendarTwo.valueAsDate = new Date(Date.UTC(dateNow.getFullYear(), dateNow.getMonth(), dateNow.getDate()));
221+
calendarTwo.valueAsDate = new Date(Date.UTC(new Date().getFullYear(), new Date().getMonth(), new Date().getDate()));
223222

224223
var tableForDaysBlock = document.createElement('div');
225224
tableForDaysBlock.id = 'tableForDaysBlock';
@@ -239,8 +238,8 @@ class UI {
239238

240239
getDateRange() {
241240
return {
242-
'from': new Date(document.getElementById('dateFrom').value).toLocaleDateString(),
243-
'to': new Date(document.getElementById('dateTo').value).toLocaleDateString()
241+
'from': new Date(document.getElementById('dateFrom').value),
242+
'to': new Date(document.getElementById('dateTo').value)
244243
};
245244
}
246245

@@ -267,7 +266,7 @@ class UI {
267266

268267
var label = this.createElement('label', ['day-block', 'lbl-toggle']);
269268
label.setAttribute('for', days[i].date);
270-
var span = this.createElement('span', ['day'], days[i].date);
269+
var span = this.createElement('span', ['day'], new Date(days[i].date).toLocaleDateString());
271270
var spanTime = this.createElement('span', ['day-time'], convertSummaryTimeToString(days[i].total));
272271

273272
label = this.appendChild(label, [span, spanTime]);
@@ -311,7 +310,7 @@ class UI {
311310
createElement(type, css, innerText){
312311
var element = document.createElement(type);
313312
if (css !== undefined && css !== null){
314-
for (let i=0; i<=css.length; i++)
313+
for (let i=0; i<css.length; i++)
315314
element.classList.add(css[i]);
316315
}
317316
if (innerText !== undefined)

src/scripts/webact.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ var totalTime;
66
var tabsFromStorage;
77
var targetTabs;
88
var currentTypeOfList;
9-
var today = new Date().toLocaleDateString();
9+
var today = new Date().toLocaleDateString("en-US");
1010
var setting_range_days;
1111
var restrictionList;
1212

@@ -264,7 +264,7 @@ function getTabsByDays(tabs) {
264264
ui.fillEmptyBlockForDays();
265265
return;
266266
}
267-
if (range.from !== 'Invalid Date' && range.to !== 'Invalid Date') {
267+
if (range.from !== 'Invalid Date' && range.to !== 'Invalid Date' && isCorrectDate(range)) {
268268
var listOfDays = [];
269269
tabs.forEach(tab => {
270270
return tab.days.forEach(day => {
@@ -284,15 +284,15 @@ function getTabsByDays(tabs) {
284284
});
285285

286286
var getDaysArray = function(start, end) {
287-
let first = new Date(start);
288-
let second = new Date(end);
287+
let first = start;
288+
let second = end;
289289
var arr = [];
290290
for (let i = first; i <= second; i = new Date(i.setDate(i.getDate() + 1))){
291-
arr.push(new Date(i).toLocaleDateString());
291+
arr.push(new Date(i).toLocaleDateString("en-US"));
292292
}
293293
return arr;
294294
};
295-
ui.fillListOfDays(listOfDays, getDaysArray(getDateValueFromString(range.from), getDateValueFromString(range.to)));
295+
ui.fillListOfDays(listOfDays, getDaysArray(range.from, range.to));
296296
}
297297
else {
298298
ui.fillEmptyBlockForDaysIfInvalid();

0 commit comments

Comments
 (0)