From 4243f2b11cb17c2c686efa656b921bab9016197d Mon Sep 17 00:00:00 2001 From: Norihiro Kamae Date: Wed, 10 Aug 2022 21:03:12 +0900 Subject: [PATCH 1/3] CI(macOS): Fix CI flow `Prepare package` step somehow failed at install_name_tool with the previous commit. So, try remove-codesign after install_name_tool. --- .github/workflows/main.yml | 4 ++++ ci/macos/download-openblas-arm64.sh | 6 ------ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 77ccc12..16b218e 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -197,6 +197,10 @@ jobs: if: ${{ github.event_name != 'pull_request' && steps.setup.outputs.haveCodesignIdent == 'true' }} run: | . ci/ci_includes.generated.sh + for dylib in release/${PLUGIN_NAME}/lib/*.dylib; do + test -f "$dylib" || continue + codesign --remove-signature "$dylib" + done for dylib in release/${PLUGIN_NAME}/*/*.{so,dylib}; do test -f "$dylib" || continue codesign --sign "${{ secrets.MACOS_SIGNING_APPLICATION_IDENTITY }}" "$dylib" diff --git a/ci/macos/download-openblas-arm64.sh b/ci/macos/download-openblas-arm64.sh index a65a757..d26b233 100755 --- a/ci/macos/download-openblas-arm64.sh +++ b/ci/macos/download-openblas-arm64.sh @@ -48,12 +48,6 @@ install_name_tool \ -id $PWD/lib/gcc/current/libgcc_s.1.1.dylib \ lib/gcc/current/libgcc_s.1.1.dylib -codesign --remove-signature lib/libopenblas.dylib -codesign --remove-signature lib/gcc/current/libgfortran.5.dylib -codesign --remove-signature lib/gcc/current/libgomp.1.dylib -codesign --remove-signature lib/gcc/current/libquadmath.0.dylib -codesign --remove-signature lib/gcc/current/libgcc_s.1.1.dylib - echo "OPENBLAS_HOME=$PWD/" >> $GITHUB_ENV cd - From 795c44a2bef0f486d1798d9e76cf2eba019651e7 Mon Sep 17 00:00:00 2001 From: Norihiro Kamae Date: Wed, 10 Aug 2022 21:05:03 +0900 Subject: [PATCH 2/3] [WIP] Build this branch --- .github/workflows/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 16b218e..ddce9b7 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -6,6 +6,7 @@ on: - '**.md' branches: - main + - fix-openblas-arm64-codesign tags: - '*' pull_request: From e286cb644fe9b3800eba5b902571b60aa703a190 Mon Sep 17 00:00:00 2001 From: Norihiro Kamae Date: Wed, 10 Aug 2022 21:15:57 +0900 Subject: [PATCH 3/3] [WIP] Print commandlines for Codesign step --- .github/workflows/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index ddce9b7..a6d1a0d 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -197,6 +197,7 @@ jobs: - name: Codesign if: ${{ github.event_name != 'pull_request' && steps.setup.outputs.haveCodesignIdent == 'true' }} run: | + set -ex . ci/ci_includes.generated.sh for dylib in release/${PLUGIN_NAME}/lib/*.dylib; do test -f "$dylib" || continue