[Bug] Added default download and upload value when assessing if a threshold was breached (alexjustesen#1218)

alexjustesen · web-flow · commit f3a29bffb713 · 2024-02-22T09:25:49.000-05:00
diff --git a/app/helpers.php b/app/helpers.php
@@ -34,14 +34,14 @@ function percentChange(float $dividend, float $divisor, int $precision = 0): str
 }
 
 if (! function_exists('absoluteDownloadThresholdFailed')) {
-    function absoluteDownloadThresholdFailed(float $threshold, float $download): bool
+    function absoluteDownloadThresholdFailed(float $threshold, float $download = 0): bool
     {
         return toBits(convertSize($download), 2) < $threshold;
     }
 }
 
 if (! function_exists('absoluteUploadThresholdFailed')) {
-    function absoluteUploadThresholdFailed(float $threshold, float $upload): bool
+    function absoluteUploadThresholdFailed(float $threshold, float $upload = 0): bool
     {
         return toBits(convertSize($upload), 2) < $threshold;
     }

Original file line number	Diff line number	Diff line change
`@@ -34,14 +34,14 @@ function percentChange(float $dividend, float $divisor, int $precision = 0): str`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`if (! function_exists('absoluteDownloadThresholdFailed')) {`
`37`		`- function absoluteDownloadThresholdFailed(float $threshold, float $download): bool`
	`37`	`+ function absoluteDownloadThresholdFailed(float $threshold, float $download = 0): bool`
`38`	`38`	`{`
`39`	`39`	`return toBits(convertSize($download), 2) < $threshold;`
`40`	`40`	`}`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`if (! function_exists('absoluteUploadThresholdFailed')) {`
`44`		`- function absoluteUploadThresholdFailed(float $threshold, float $upload): bool`
	`44`	`+ function absoluteUploadThresholdFailed(float $threshold, float $upload = 0): bool`
`45`	`45`	`{`
`46`	`46`	`return toBits(convertSize($upload), 2) < $threshold;`
`47`	`47`	`}`