Skip to content

Commit dbac310

Browse files
committed
Correct links for facebook/github/twitter/mailto
1 parent 76eac7b commit dbac310

File tree

8 files changed

+46
-31
lines changed

8 files changed

+46
-31
lines changed

_config.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ features :
3636

3737
# Theme Settings
3838
accent_color : "#1d63ea"
39+
primary_text_color : "#000000"
40+
secondary_text_color : "#666666"
3941

4042
header_color : "#000000"
4143
header_transparency : 0.1

_includes/features.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@
1010
</span>
1111
</div>
1212
<div class="featureText">
13-
<h4>
13+
<h3>
1414
{{ feature.title }}
15-
</h4>
15+
</h3>
1616
<p>
1717
{{ feature.description }}
1818
</p>

_includes/footer.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<div class="footerIcons">
44

55
{% if site.facebook_username %}
6-
<a href="https://">
6+
<a href="https://facebook.com/{{ site.facebook_username }}">
77
<span class="fa-stack fa-1x">
88
<i class="socialIconBack fas fa-circle fa-stack-2x"></i>
99
<i class="socialIconTop fab fa-facebook fa-stack-1x"></i>
@@ -21,7 +21,7 @@
2121
{% endif %}
2222

2323
{% if site.github_username %}
24-
<a href="https://">
24+
<a href="https://github.com/{{ site.github_username }}">
2525
<span class="fa-stack fa-1x">
2626
<i class="socialIconBack fas fa-circle fa-stack-2x"></i>
2727
<i class="socialIconTop fab fa-github fa-stack-1x"></i>
@@ -30,7 +30,7 @@
3030
{% endif %}
3131

3232
{% if site.email_address %}
33-
<a href="https://">
33+
<a href="mailto:{{ site.email_address }}">
3434
<span class="fa-stack fa-1x">
3535
<i class="socialIconBack fas fa-circle fa-stack-2x"></i>
3636
<i class="socialIconTop fas fa-envelope fa-stack-1x"></i>

_includes/header.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
</svg>
1212
<img class="headerIcon" src="/assets/appicon-1024px.png">
1313
</div>
14-
<h4>Your App</h4>
14+
<p>{{ site.app_name }}</p>
1515
</div>
1616
<nav>
1717
<ul>

_sass/base.scss

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ $primary-text-color: #000;
88
html {
99
font-size: 62.5%;
1010
font-family: $font;
11+
line-height: 1;
1112
}
1213

1314
body {
@@ -19,14 +20,10 @@ h1 {
1920
}
2021

2122
h2 {
22-
font-size: 4rem;
23+
font-size: 2rem;
2324
}
2425

2526
h3 {
26-
font-size: 3rem;
27-
}
28-
29-
h4 {
3027
font-size: 2rem;
3128
}
3229

@@ -41,6 +38,7 @@ a:hover,
4138
a:visited,
4239
a:active {
4340
color: $accent-color;
41+
text-decoration: none;
4442
}
4543

4644
// Shadows

_sass/layout.scss

Lines changed: 28 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -38,20 +38,24 @@
3838

3939
header {
4040
grid-area: h;
41-
display: grid;
42-
grid-template-columns: repeat(12, 1fr);
43-
grid-template-rows: 115px;
41+
display: flex;
4442
}
4543

4644
.logo {
47-
grid-column: 1 / span 6;
45+
width: 50%;
4846
display: flex;
4947
justify-content: flex-start;
5048
align-items: center;
51-
color: #fff;
5249
height: 115px;
5350
}
5451

52+
.logo > p {
53+
color: #fff;
54+
display: flex;
55+
font-weight: bold;
56+
padding-bottom: 1px;
57+
}
58+
5559
.headerIcon {
5660
width: 50px;
5761
height: 50px;
@@ -61,15 +65,15 @@ header {
6165
}
6266

6367
nav {
64-
grid-column: 7 / span 6;
68+
width: 50%;
6569
display: flex;
6670
justify-content: flex-end;
6771
align-items: center;
68-
color: #fff;
6972
height: 115px;
7073
}
7174

7275
nav > ul {
76+
color: #fff;
7377
display: flex;
7478
list-style-type: none;
7579
}
@@ -82,9 +86,16 @@ nav > ul li:first-child {
8286
padding-left: 0px;
8387
}
8488

85-
nav > ul li a {
89+
nav > ul li a:link,
90+
nav > ul li a:visited {
8691
text-decoration: none;
87-
color: #fff;
92+
color: rgba(#fff, 0.6);
93+
}
94+
95+
nav > ul li a:hover,
96+
nav > ul li a:active {
97+
text-decoration: none;
98+
color: rgba(#fff, 1);
8899
}
89100

90101
.appInfo {
@@ -96,7 +107,6 @@ nav > ul li a {
96107
}
97108

98109
.appIconShadow {
99-
display: flex;
100110
filter: $drop-shadow;
101111
}
102112

@@ -109,21 +119,19 @@ nav > ul li a {
109119
}
110120

111121
.appNamePriceContainer {
122+
display: flex;
112123
height: 120px;
113124
flex: 0 1 auto;
114-
align-items: flex-center;
115-
align-content: center;
125+
align-items: center;
116126
}
117127

118128
.appName {
119129
color: #fff;
120-
margin-top: -4px;
121130
}
122131

123132
.appPrice {
124133
color: #fff;
125134
font-weight: normal;
126-
padding-top: 8px;
127135
}
128136

129137
.appDescriptionContainer {
@@ -135,7 +143,6 @@ nav > ul li a {
135143

136144
.appDescription {
137145
color: #fff;
138-
font-weight: normal;
139146
}
140147

141148
.downloadButtonsContainer {
@@ -225,7 +232,12 @@ nav > ul li a {
225232
margin-left: 18px;
226233
}
227234

235+
.featureText > h3 {
236+
color: $primary-text-color;
237+
}
238+
228239
.featureText > p {
240+
color: $secondary-text-color;
229241
margin-top: 8px;
230242
line-height: 1.5;
231243
}
@@ -239,6 +251,7 @@ footer {
239251
}
240252

241253
.footerText {
254+
color: $secondary-text-color;
242255
display: block;
243256
width: 100%;
244257
text-align: center;

css/main.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
---
44

55
$header-image: '{{ site.header_image }}';
6+
$primary-text-color: {{ site.primary_text_color }};
7+
$secondary-text-color: {{ site.secondary_text_color }};
68

79
$accent-color: {{ site.accent_color }};
810

index.html

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
</svg>
2222
{% if site.app_video %}
2323
<div class="videoContainer">
24-
<video controls="controls">
24+
<video poster="/assets/Screenshot.png" autoplay="autoplay" controls="controls">
2525
<source src="{{ site.app_video }}" type="video/mp4">
2626
</video>
2727
</div>
@@ -44,14 +44,14 @@
4444
<h1 class="appName">
4545
{{ site.app_name }}
4646
</h1>
47-
<h3 class="appPrice">
47+
<h2 class="appPrice">
4848
${{ site.app_price }}
49-
</h3>
49+
</h2>
5050
</div>
5151
<div class="appDescriptionContainer">
52-
<h4 class ="appDescription">
52+
<p class ="appDescription">
5353
{{ site.app_description }}
54-
</h4>
54+
</p>
5555
</div>
5656
<div class="downloadButtonsContainer">
5757
<a href="https://"><img class="playStore" src="/assets/playstore.png"></a>

0 commit comments

Comments
 (0)