js fixes for firefox

Author: puthre

js/clients.js

@@ -12,6 +12,8 @@
             });
           });
         $("#new-client-submit").click(function () {
+            if ($("#new-client-input").val().trim() == '')
+              return false;
             var baseUrl = OC.generateUrl('/apps/timetracker/ajax/add-client/'+$("#new-client-input").val());
             var jqxhr = $.post( baseUrl, function() {
                 getClients();
@@ -26,6 +28,7 @@
                 .fail(function() {
                   alert( "error" );
                 })
+            return false;
         });
         dialogClientEditForm = $( "#dialog-client-edit-form" ).dialog({
             autoOpen: false,
@@ -35,12 +38,14 @@
             buttons: {
               "Edit client": {click:function(){
                   editClient(dialogClientEditForm);
+                  return false;
               },
               text: 'Edit client',
               class: 'primary'
             },
               Cancel: function() {
                 dialogClientEditForm.dialog( "close" );
+                return false;
               }
             },
             close: function() {
@@ -104,7 +109,7 @@
                     form = dialogClientEditForm.find( "form" )
                     form.find("#name").val($(e.target).data("name"));
                     dialogClientEditForm.dialog("open");
-                    
+                    return false;
 
 
                 })
@@ -129,16 +134,19 @@
                                     .always(function() {
 
                                     });
+                            return false;
                           },
                         text: 'Confirm',
                         class: 'primary'
                         },
                           "Cancel" : function() {
                             $(this).dialog("close");
+                            return false;
                           }
                         }
                       });
                     $("#dialog-confirm").dialog("open");
+                  return false;
                 })
               });
         }

js/projects.js

@@ -47,6 +47,8 @@
             if (selectedClient !== null){
               clientId = selectedClient.id;
             }
+            if ($("#new-project-input").val().trim() == '')
+              return false;
             var baseUrl = OC.generateUrl('/apps/timetracker/ajax/add-project/'+$("#new-project-input").val());
             var jqxhr = $.post( baseUrl, {clientId:clientId} ,function() {
                 getProjects();
@@ -61,6 +63,7 @@
                 .fail(function() {
                   alert( "error" );
                 });
+          return false;
         });
         dialogProjectEditForm = $( "#dialog-project-edit-form" ).dialog({
             autoOpen: false,
@@ -77,6 +80,7 @@
                    } else {
                     $("#locked-options").addClass('hidden');
                    }
+                  
                 });
               }
 
@@ -335,7 +339,7 @@
               rowClick:function(e, row){
 
                 if (!isAdmin() && row.getData().locked){
-                  return;
+                  return false;
                 }
                 e.preventDefault();
                 dialogProjectEditForm.target = row;
@@ -368,7 +372,7 @@
                   }
                 }
                 dialogProjectEditForm.dialog("open");
-
+                return false;
               },
               ajaxResponse:function(url, params, response){
 

js/reports.js

@@ -189,9 +189,11 @@
               });
               $("#download-csv").click(function(){
                 table.download("csv", "data.csv");
+                return false;
             });
             $("#download-json").click(function(){
               table.download("json", "data.json");
+              return false;
             });
           }
       });

js/tags.js

@@ -11,6 +11,8 @@
             });
           });
         $("#new-tag-submit").click(function () {
+          if ($("#new-tag-input").val().trim() == '')
+              return false;
             var baseUrl = OC.generateUrl('/apps/timetracker/ajax/add-tag/'+$("#new-tag-input").val());
             var jqxhr = $.post( baseUrl, function() {
 
@@ -26,6 +28,7 @@
                 .fail(function() {
                   alert( "error" );
                 })
+          return false;
         });
         dialogTagEditForm = $( "#dialog-tag-edit-form" ).dialog({
             autoOpen: false,
@@ -35,6 +38,7 @@
             buttons: {
               "Edit tag": {click: function(){
                   editTag(dialogTagEditForm);
+                  return false;
               },
               text: 'Edit tag',
               class:'primary'
@@ -104,7 +108,7 @@
                     dialogTagEditForm.dialog("open");
 
 
-
+                    return false;
                 })
                 $('.tag-delete').click(function(e) {
                     $("#dialog-confirm").dialog({
@@ -124,6 +128,7 @@
                                     .fail(function() {
                                     alert( "error" );
                                     })
+                                    return false;
                           },
                           text: 'Confirm',
                           class:'primary'
@@ -134,6 +139,7 @@
                         }
                       });
                     $("#dialog-confirm").dialog("open");
+                    return false;
                 })
               });
         }

js/timer.js

@@ -187,12 +187,14 @@
                     form = dialogWorkItemEditForm.find( "form" )
                     form.find("#name").val($(e.target).data("name"));
                     dialogWorkItemEditForm.dialog("open");
+                    return false;
 
                 })
                 $('.wi-play').click(function(e) {
                     e.preventDefault();
                     $('#work-input').val($(this).data('work-name'));
                     startTimer();
+                    return false;
                 })
                 $('.wi-trash').click(function(e) {
                     $("#dialog-confirm").dialog({
@@ -216,6 +218,7 @@
                         }
                       });
                     $("#dialog-confirm").dialog("open");
+                    return false;
                 });
 
                 $(".set-project").each(function(){
@@ -404,6 +407,7 @@
             } else {
                 startTimer();
             }
+            return false;
           });
       } );