Skip to content

Commit eedacba

Browse files
committed
Removed unnecessary assertion and import statements
1 parent 8501566 commit eedacba

2 files changed

Lines changed: 2 additions & 10 deletions

File tree

CHANGES.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ Version 0.2.0 (2014-xx-xx)
22
--------------------------
33
Changed track screen view to use an unstructured event (#53) (TODO)
44
Added ability to name individual instances of the Python Tracker (#52) (TODO)
5-
Validate GET payload in all integration tests (#33) (TODO)
5+
Validated GET payload in all integration tests (#33) (TODO)
66
Added support for Python 3.2 (#41) (TODO)
77
Added support for Python 2.7 (#42) (TODO)
88
Fixed versions in requirements.txt (#47)

snowplow_tracker/test/integration/test_integration.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,19 +18,13 @@
1818
Copyright: Copyright (c) 2013-2014 Snowplow Analytics Ltd
1919
License: Apache License Version 2.0
2020
'''
21-
import requests
21+
2222
import unittest
2323
import time
2424
import re
2525
from snowplow_tracker import tracker
2626
from httmock import all_requests, HTTMock
2727

28-
'''
29-
@all_requests
30-
def pass_response_content(url, request):
31-
return 'True'
32-
'''
33-
3428
def from_querystring(field, url):
3529
pattern = re.compile('^[^#]*[?&]' + field + '=([^&#]*)')
3630
match = pattern.match(url)
@@ -86,7 +80,6 @@ def test_integration_struct_event(self):
8680
with HTTMock(pass_response_content):
8781
val = t.track_struct_event('Ecomm', 'add-to-basket', 'dog-skateboarding-video', 'hd', 13.99)
8882
assertion_array = {'se_ca': 'Ecomm', 'se_pr': 'hd', 'se_la': 'dog-skateboarding-video', 'se_va': '13.99', 'se_ac': 'add-to-basket', 'e': 'se'}
89-
self.assertTrue(val)
9083
for key in assertion_array:
9184
self.assertEquals(from_querystring(key, val), assertion_array[key])
9285

@@ -96,7 +89,6 @@ def test_integration_unstruct_event_non_base64(self):
9689
t.config['encode_base64'] = False
9790
with HTTMock(pass_response_content):
9891
val = t.track_unstruct_event('viewed_product', {'product_id': 'ASO01043', 'price$flt': 49.95, 'walrus$tms': int(time.time() * 1000),})
99-
self.assertTrue(val)
10092
assertion_array = {'e': 'ue', 'ue_na': 'viewed_product'}
10193
for key in assertion_array:
10294
self.assertEquals(from_querystring(key, val), assertion_array[key])

0 commit comments

Comments
 (0)