Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: matomo-org/matomo-php-tracker
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: matomo-org/matomo-php-tracker
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fix-page-url-detection-request-uri
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Jul 27, 2026

  1. Detect the tracked page URL from REQUEST_URI, not PATH_INFO (#141) 

    getCurrentScriptName() builds the auto-detected page URL (the path
between host and query string). It preferred $_SERVER['PATH_INFO'],
which only holds the trailing path-info segment — so with front-
controller / path-info routing (e.g. /dir1/page handled by
dir1/index.php) the tracker recorded a truncated '/page' instead of
'/dir1/page'.

REQUEST_URI already contains the full requested path (PATH_INFO is
always just a suffix of it), so use it as the source and drop PATH_INFO
entirely; SCRIPT_NAME stays as the fallback when REQUEST_URI is absent.
This also aligns the primary source with Matomo core's Url helper.

Reported in #141.
    @sgiehl
    sgiehl committed Jul 27, 2026
    Configuration menu
    Copy the full SHA
    d54ed8a View commit details
    Browse the repository at this point in the history

  2. Drop the ticket number from an inline test comment 

    Keep issue references in the CHANGELOG and git history, not in code.
    @sgiehl
    sgiehl committed Jul 27, 2026
    Configuration menu
    Copy the full SHA
    0232a48 View commit details
    Browse the repository at this point in the history
Loading