Skip to content

Commit 4def104

Browse files
Jack-Keenematus-tomlein
authored andcommitted
Export MediaEventType from media plugin (Close snowplow#1315)
PR snowplow#1316 * Expose MediaEventType from media plugin api
1 parent 16f216e commit 4def104

3 files changed

Lines changed: 33 additions & 5 deletions

File tree

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{
2+
"changes": [
3+
{
4+
"packageName": "@snowplow/browser-plugin-media",
5+
"comment": "Expose MediaEventType",
6+
"type": "none"
7+
}
8+
],
9+
"packageName": "@snowplow/browser-plugin-media"
10+
}
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{
2+
"changes": [
3+
{
4+
"packageName": "@snowplow/browser-tracker",
5+
"comment": "Expose MediaEventType",
6+
"type": "none"
7+
}
8+
],
9+
"packageName": "@snowplow/browser-tracker"
10+
}

plugins/browser-plugin-media/src/api.ts

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import {
2323
EventWithContext,
2424
} from './types';
2525

26-
export { MediaAdBreakType as MediaPlayerAdBreakType };
26+
export { MediaAdBreakType as MediaPlayerAdBreakType, MediaEventType };
2727

2828
const _trackers: Record<string, BrowserTracker> = {};
2929
const _context: Record<string, SelfDescribingJson[]> = {};
@@ -396,7 +396,9 @@ export function trackMediaAdSkip(
396396
trackers: Array<string> = Object.keys(_trackers)
397397
) {
398398
let { percentProgress } = args;
399-
if (percentProgress !== undefined) { percentProgress = Math.floor(percentProgress); }
399+
if (percentProgress !== undefined) {
400+
percentProgress = Math.floor(percentProgress);
401+
}
400402
track(
401403
{
402404
mediaEvent: {
@@ -506,7 +508,9 @@ export function trackMediaAdClick(
506508
trackers: Array<string> = Object.keys(_trackers)
507509
) {
508510
let { percentProgress } = args;
509-
if (percentProgress !== undefined) { percentProgress = Math.floor(percentProgress); }
511+
if (percentProgress !== undefined) {
512+
percentProgress = Math.floor(percentProgress);
513+
}
510514
track(
511515
{
512516
mediaEvent: {
@@ -534,7 +538,9 @@ export function trackMediaAdPause(
534538
trackers: Array<string> = Object.keys(_trackers)
535539
) {
536540
let { percentProgress } = args;
537-
if (percentProgress !== undefined) { percentProgress = Math.floor(percentProgress); }
541+
if (percentProgress !== undefined) {
542+
percentProgress = Math.floor(percentProgress);
543+
}
538544
track(
539545
{
540546
mediaEvent: {
@@ -563,7 +569,9 @@ export function trackMediaAdResume(
563569
trackers: Array<string> = Object.keys(_trackers)
564570
) {
565571
let { percentProgress } = args;
566-
if (percentProgress !== undefined) { percentProgress = Math.floor(percentProgress); }
572+
if (percentProgress !== undefined) {
573+
percentProgress = Math.floor(percentProgress);
574+
}
567575
track(
568576
{
569577
mediaEvent: {

0 commit comments

Comments
 (0)