Skip to content

Commit 22838b3

Browse files
fblundunalexanderdean
authored andcommitted
Updated trackAddToCart, trackRemoveFromCart, and trackSiteSearch with new parameter names and types
1 parent 44b451f commit 22838b3

2 files changed

Lines changed: 13 additions & 10 deletions

File tree

examples/web/async-large.html

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,10 @@
196196
alert('Searching the site');
197197
window.snowplow_1('trackSiteSearch',
198198
['event', 'analytics'], // search terms - required
199-
['books', 'safe search'], // search filters
199+
{ // search filters
200+
category: 'books',
201+
safeSearch: true
202+
},
200203
15, // number of results returned
201204
10 // number of results displayed on page
202205
);

src/js/tracker.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1316,13 +1316,13 @@
13161316
* @param string sku Required. Item's SKU code.
13171317
* @param string name Optional. Product name.
13181318
* @param string category Optional. Product category.
1319-
* @param string price Required. Product price.
1319+
* @param string unitPrice Optional. Product price.
13201320
* @param string quantity Required. Quantity added.
13211321
* @param string currency Optional. Product price currency.
13221322
* @param array context Optional. Context relating to the event.
13231323
*/
1324-
trackAddToCart: function(sku, name, category, price, quantity, currency, context) {
1325-
core.trackAddToCart(sku, name, category, price, quantity, currency, context);
1324+
trackAddToCart: function(sku, name, category, unitPrice, quantity, currency, context) {
1325+
core.trackAddToCart(sku, name, category, unitPrice, quantity, currency, context);
13261326
},
13271327

13281328
/**
@@ -1331,22 +1331,22 @@
13311331
* @param string sku Required. Item's SKU code.
13321332
* @param string name Optional. Product name.
13331333
* @param string category Optional. Product category.
1334-
* @param string price Required. Product price.
1334+
* @param string unitPrice Optional. Product price.
13351335
* @param string quantity Required. Quantity removed.
13361336
* @param string currency Optional. Product price currency.
13371337
* @param array context Optional. Context relating to the event.
13381338
*/
1339-
trackRemoveFromCart: function(sku, name, category, price, quantity, currency, context) {
1340-
core.trackRemoveFromCart(sku, name, category, price, quantity, currency, context);
1339+
trackRemoveFromCart: function(sku, name, category, unitPrice, quantity, currency, context) {
1340+
core.trackRemoveFromCart(sku, name, category, unitPrice, quantity, currency, context);
13411341
},
13421342

13431343
/**
13441344
* Track an internal search event
13451345
*
13461346
* @param array terms Search terms
1347-
* @param array filters Search filters
1348-
* @param totalResults Number of results
1349-
* @param pageResults Number of results displayed on page
1347+
* @param object filters Search filters
1348+
* @param number totalResults Number of results
1349+
* @param number pageResults Number of results displayed on page
13501350
* @param array context Optional. Context relating to the event.
13511351
*/
13521352
trackSiteSearch: function(terms, filters, totalResults, pageResults, context) {

0 commit comments

Comments
 (0)