[Improvement] Add placeholder for failed test without message field (alexjustesen#1940)

svenvg93 · web-flow · commit c37f0bdb2d0b · 2024-12-18T21:11:53.000-05:00
diff --git a/app/Helpers/Ookla.php b/app/Helpers/Ookla.php
@@ -20,7 +20,8 @@ public static function getErrorMessage(ProcessFailedException $exception): strin
                 return $decoded['message'];
             }
 
-            return ''; // If it's not valid JSON or doesn't contain "message", return an empty string
+            // Placeholder for invalid JSON or missing "message"
+            return 'An unexpected error occurred while running the Ookla CLI.';
         }, $messages);
 
         // Filter out empty messages and concatenate

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,8 @@ public static function getErrorMessage(ProcessFailedException $exception): strin`
`20`	`20`	`return $decoded['message'];`
`21`	`21`	`}`
`22`	`22`
`23`		`- return ''; // If it's not valid JSON or doesn't contain "message", return an empty string`
	`23`	`+ // Placeholder for invalid JSON or missing "message"`
	`24`	`+ return 'An unexpected error occurred while running the Ookla CLI.';`
`24`	`25`	`}, $messages);`
`25`	`26`
`26`	`27`	`// Filter out empty messages and concatenate`