Skip to content

fix: TTL-888 special characters searching tech #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2023
Merged

fix: TTL-888 special characters searching tech #989

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0464779
fix: TTL-888 special characters searching tech
mmaquina May 24, 2023
ce0553c
test: TTL-888 added test for searching tech with special characters
mmaquina May 24, 2023
da4c362
fix: TTL-888 describe instead of fdescribe
mmaquina May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: TTL-888 added test for searching tech with special characters
  • Loading branch information
@mmaquina
mmaquina committed May 24, 2023
commit ce0553ceb71ed846f237a79031d2b5c38a26ec1e
17 changes: 16 additions & 1 deletion src/app/modules/shared/services/technology.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,12 @@ import { Technology } from '../../shared/models';
import { TechnologyService } from './technology.service';
import { STACK_EXCHANGE_ID, STACK_EXCHANGE_ACCESS_TOKEN } from '../../../../environments/environment';

describe('TechnologyService', () => {
fdescribe('TechnologyService', () => {
let service: TechnologyService;
let httpMock: HttpTestingController;

const technologyList: Technology = { items: [{ name: 'java' }, { name: 'javascript' }] };
const technologyListWithSpecialChar: Technology = { items: [{ name: 'c#' }, { name: 'c#-2.0' }] };

beforeEach(() => {
TestBed.configureTestingModule({
Expand Down Expand Up @@ -42,4 +43,18 @@ describe('TechnologyService', () => {
expect(getTechnologiesRequest.request.method).toBe('GET');
getTechnologiesRequest.flush(technologyList);
});

it('technologies with special characters are read using GET from url', () => {
const technologyFoundSize = technologyListWithSpecialChar.items.length;
const technologyName = 'c#';
service.getTechnologies(technologyName).subscribe((technologyInResponse) => {
expect(technologyInResponse.items.length).toBe(technologyFoundSize);
});
const getTechnologiesRequest = httpMock.expectOne(
`${service.baseUrl}&inname=${encodeURIComponent(technologyName)}&site=stackoverflow&key=${STACK_EXCHANGE_ID}&access_token=${STACK_EXCHANGE_ACCESS_TOKEN}`
);
expect(getTechnologiesRequest.request.method).toBe('GET');
getTechnologiesRequest.flush(technologyListWithSpecialChar);
});

});