Skip to content

TTL-720-bug-as-a-software-developer-i-want-to-fix-table-of-customers #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

TTL-720-bug-as-a-software-developer-i-want-to-fix-table-of-customers #958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: TTL-720 customers datatable is now orderable, shows correct summary
  • Loading branch information
@mmaquina
mmaquina committed Dec 2, 2022
commit 549c197bf77f8ab07fe55080e7848ff5490a2467
8 changes: 4 additions & 4 deletions ...management/components/customer-info/components/customer-list/customer-list.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,17 @@
>
<thead class="thead-blue">
<tr class="d-flex">
<th class="col-4 text-center">Customer ID</th>
<th class="col-4 text-center">Name</th>
<th class="col-2 text-center">Customer ID</th>
<th class="col-6 text-center">Name</th>
<th class="col-2 text-center">Options</th>
<th class="col-2 text-center">Visibility</th>
</tr>
</thead>
<app-loading-bar *ngIf="(isLoading$ | async)"></app-loading-bar>
<tbody *ngIf="((isLoading$ | async) === false)">
<tr class="d-flex" *ngFor="let customer of customers">
<td class="col-4 text-break">{{ customer.id }}</td>
<td class="col-4 text-break">{{ customer.name }}</td>
<td class="col-2 text-break">{{ customer.id }}</td>
<td class="col-6 text-break">{{ customer.name }}</td>
<td class="col-2 text-center">
<button
data-toggle="modal"
Expand Down
6 changes: 5 additions & 1 deletion ...r-management/components/customer-info/components/customer-list/customer-list.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,12 @@ export class CustomerListComponent implements OnInit, OnDestroy, AfterViewInit {
@Input()
customers: CustomerUI[] = [];
dtOptions: any = {
columnDefs: [{orderable: false, targets: [2]}]
dom: '<"d-flex justify-content-between"B<"d-flex"<"mr-5"l>f>>rtip',
columnDefs: [
{orderable: false, targets: [2]}
]
};

dtTrigger: Subject<any> = new Subject();
@ViewChild(DataTableDirective, { static: false })
dtElement: DataTableDirective;
Expand Down