Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: TTA-193 increase code coverage
  • Loading branch information
andresacg30 committed Oct 7, 2022
commit 0a07ce97f68fb092505798a564c6a8b2ca37f4c5
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ describe('SpinnerInterceptorService test', () => {

it('if request is made then spinnerInterceptor is called', () => {
const request = new HttpRequest('GET', '/foo');
spyOn(spinnerInterceptor, 'intercept');


spyOn(spinnerInterceptor, 'intercept').and.callThrough();

spinnerInterceptor.intercept(request, httpHandler);

Expand Down
18 changes: 16 additions & 2 deletions src/app/modules/shared/services/spinner-overlay.service.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import { SpinnerOverlayService } from './spinner-overlay.service';
import { SpinnerInterceptor } from '../interceptors/spinner.interceptor';
import { HttpEvent, HttpHandler, HttpRequest, HttpResponse, HTTP_INTERCEPTORS } from '@angular/common/http';
import { Observable, of } from 'rxjs';
import { ComponentPortal } from 'ngx-toastr';


describe('SpinnerOverlayService test', () => {

Expand All @@ -17,7 +19,7 @@ describe('SpinnerOverlayService test', () => {
let spinnerService: SpinnerOverlayService;
let spinnerInterceptor: SpinnerInterceptor;
let mockHttpHandler: HttpHandler;

let overlayRef: any;

beforeEach(() => {
TestBed.configureTestingModule({
Expand All @@ -34,6 +36,7 @@ describe('SpinnerOverlayService test', () => {
spinnerService = TestBed.inject(SpinnerOverlayService);
spinnerInterceptor = TestBed.inject(SpinnerInterceptor);
mockHttpHandler = new MockHttpHandler();
overlayRef = spinnerService.overlayRef;
});

it('should be created', () => {
Expand All @@ -42,10 +45,21 @@ describe('SpinnerOverlayService test', () => {

it('if request is made then spinnerService is show', () => {
const request = new HttpRequest('GET', '/foo');
spyOn<any>(spinnerService, 'show');
spyOn(spinnerService, 'show');

spinnerInterceptor.intercept(request, mockHttpHandler);

expect(spinnerService.show).toHaveBeenCalled();
expect(overlayRef).toBeUndefined();
expect(ComponentPortal).toBeTruthy();
});

it('if request is made then spinnerService is hide', () => {
const request = new HttpRequest('GET', '/foo');
spyOn(spinnerService, 'hide');

spinnerInterceptor.intercept(request, mockHttpHandler);

expect(spinnerService.hide).toBeTruthy();
});
});
4 changes: 2 additions & 2 deletions src/app/modules/shared/services/spinner-overlay.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { SpinnerOverlayComponent } from './../components/spinner-overlay/spinner
providedIn: 'root',
})
export class SpinnerOverlayService {
private overlayRef: OverlayRef = undefined;
public overlayRef: OverlayRef = undefined;
static spinner$: any;

constructor(private readonly overlay: Overlay) {}
Expand Down Expand Up @@ -41,4 +41,4 @@ export class SpinnerOverlayService {
this.overlayRef.detach();
this.overlayRef = undefined;
}
}
};