From 724ef671783a9601a52a5498f9ddf2dab6975f65 Mon Sep 17 00:00:00 2001
From: jr-98 <jonathan.tillaguango@unl.edu.ec>
Date: Wed, 27 Jan 2021 11:11:46 -0500
Subject: [PATCH 1/4] fix: TT-139  Reduce the left margin on coutome page

---
 .../customer-list/customer-list.component.html     | 14 +++++++-------
 .../customer-list/customer-list.component.ts       |  5 +++--
 .../pages/customer.component.html                  |  2 +-
 3 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.html b/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.html
index 784ddf685..f8af93e2d 100644
--- a/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.html
+++ b/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.html
@@ -1,23 +1,23 @@
 <table
   *ngIf="customers"
-  class="table table-sm table-bordered table-striped mb-0"
+  class="table table-responsive-sm table-bordered table-striped mb-0"
   datatable
   [dtTrigger]="dtTrigger"
   [dtOptions]="dtOptions"
 >
   <thead class="thead-blue">
     <tr class="d-flex">
-      <th class="col-4">Customer ID</th>
-      <th class="col-5">Name</th>
-      <th class="col-3 text-center">Options</th>
+      <th class="col-sm-4">Customer ID</th>
+      <th class="col-sm-5">Name</th>
+      <th class="col-sm-3 text-center">Options</th>
     </tr>
   </thead>
   <app-loading-bar *ngIf="(isLoading$ | async)"></app-loading-bar>
   <tbody *ngIf="((isLoading$ | async) === false)">
     <tr class="d-flex" *ngFor="let customer of customers">
-      <td class="col-sm-4">{{ customer.id }}</td>
-      <td class="col-sm-5">{{ customer.name }}</td>
-      <td class="col-sm-3 text-center">
+      <td class="col col-sm-4">{{ customer.id }}</td>
+      <td class="col col-sm-5">{{ customer.name }}</td>
+      <td class="col col-sm-3 text-center">
         <button
           (click)="editCustomer(customer.id)"
           type="button"
diff --git a/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.ts b/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.ts
index ed46b8b94..e5c9785ed 100644
--- a/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.ts
+++ b/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.ts
@@ -40,8 +40,9 @@ export class CustomerListComponent implements OnInit, OnDestroy, AfterViewInit {
 
   ngOnInit(): void {
     this.dtOptions = {
-      scrollY: '290px',
+      scrollY: '325px',
       paging: false,
+      responsive: true,
     };
     this.loadCustomersSubscription = this.actionsSubject$
       .pipe(filter((action: any) => action.type === CustomerManagementActionTypes.LOAD_CUSTOMERS_SUCCESS))
@@ -49,7 +50,6 @@ export class CustomerListComponent implements OnInit, OnDestroy, AfterViewInit {
         this.customers = action.payload;
         this.rerenderDataTable();
       });
-
     this.changeCustomerSubscription = this.actionsSubject$
       .pipe(
         filter(
@@ -109,4 +109,5 @@ export class CustomerListComponent implements OnInit, OnDestroy, AfterViewInit {
     this.message = `Are you sure you want to delete ${item.name}?`;
     this.showModal = true;
   }
+
 }
diff --git a/src/app/modules/customer-management/pages/customer.component.html b/src/app/modules/customer-management/pages/customer.component.html
index c56abeef8..a97e5d8aa 100644
--- a/src/app/modules/customer-management/pages/customer.component.html
+++ b/src/app/modules/customer-management/pages/customer.component.html
@@ -1,4 +1,4 @@
-<div class="container">
+<div class="container-fluid px-0 full-height">
   <div class="row">
     <div style="padding: 15px;">
       <button (click)="activateCustomerForm()" class="btn btn-primary">Add new customer</button>

From 88d48718737599a5d3aaa73a9f63c5bbaaaa5f51 Mon Sep 17 00:00:00 2001
From: jr-98 <jonathan.tillaguango@unl.edu.ec>
Date: Wed, 27 Jan 2021 22:28:15 -0500
Subject: [PATCH 2/4] fix: TT-139-Reduce-the-left-margin-on-the-customer-page2

---
 .../activity-list/activity-list.component.html |  2 +-
 .../customer-list/customer-list.component.html | 18 ++++++++++--------
 .../customer-list/customer-list.component.scss |  4 ++++
 3 files changed, 15 insertions(+), 9 deletions(-)

diff --git a/src/app/modules/activities-management/components/activity-list/activity-list.component.html b/src/app/modules/activities-management/components/activity-list/activity-list.component.html
index a4582ed10..903587928 100644
--- a/src/app/modules/activities-management/components/activity-list/activity-list.component.html
+++ b/src/app/modules/activities-management/components/activity-list/activity-list.component.html
@@ -4,7 +4,7 @@
       <tr class="d-flex">
         <th class="col-4">Activity ID</th>
         <th class="col-5">Activity</th>
-        <th class="col-3 text-center"></th>
+        <th class="col-3 text-center">Options</th>
       </tr>
     </thead>
     <app-loading-bar *ngIf="(isLoading$ | async)"></app-loading-bar>
diff --git a/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.html b/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.html
index f8af93e2d..711471409 100644
--- a/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.html
+++ b/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.html
@@ -1,23 +1,24 @@
-<table
+<div class="table table-responsive">
+  <table
   *ngIf="customers"
-  class="table table-responsive-sm table-bordered table-striped mb-0"
+class="table table-bordered table-striped"
   datatable
   [dtTrigger]="dtTrigger"
   [dtOptions]="dtOptions"
 >
   <thead class="thead-blue">
     <tr class="d-flex">
-      <th class="col-sm-4">Customer ID</th>
-      <th class="col-sm-5">Name</th>
-      <th class="col-sm-3 text-center">Options</th>
+      <th class="col-5 text-center">Customer ID</th>
+      <th class="col-3 text-center">Name</th>
+      <th class="col-4 text-center">Options</th>
     </tr>
   </thead>
   <app-loading-bar *ngIf="(isLoading$ | async)"></app-loading-bar>
   <tbody *ngIf="((isLoading$ | async) === false)">
     <tr class="d-flex" *ngFor="let customer of customers">
-      <td class="col col-sm-4">{{ customer.id }}</td>
-      <td class="col col-sm-5">{{ customer.name }}</td>
-      <td class="col col-sm-3 text-center">
+      <td class="col-5">{{ customer.id }}</td>
+      <td class="col-3">{{ customer.name }}</td>
+      <td class="col-4 text-center">
         <button
           (click)="editCustomer(customer.id)"
           type="button"
@@ -38,6 +39,7 @@
     </tr>
   </tbody>
 </table>
+</div>
 
 <app-dialog
   *ngIf="showModal"
diff --git a/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.scss b/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.scss
index e69de29bb..9d5a604f4 100644
--- a/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.scss
+++ b/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.scss
@@ -0,0 +1,4 @@
+.col-3 .col-4 .col-5 {
+  padding: 1rem 0rem 2rem;
+  overflow: hidden;
+}

From 6bf77351318e0db902cb7dcbf6e7c90aa7ec0be8 Mon Sep 17 00:00:00 2001
From: jr-98 <jonathan.tillaguango@unl.edu.ec>
Date: Thu, 28 Jan 2021 19:35:30 -0500
Subject: [PATCH 3/4] fix: TT-139 Resolved the cometaries on GitHub about
 identation and bootstrap

---
 .../customer-list.component.html              | 80 +++++++++----------
 .../customer-list.component.scss              |  5 +-
 2 files changed, 41 insertions(+), 44 deletions(-)

diff --git a/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.html b/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.html
index 711471409..09b7a0b76 100644
--- a/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.html
+++ b/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.html
@@ -1,44 +1,44 @@
-<div class="table table-responsive">
+<div class="table-responsive-sm">
   <table
-  *ngIf="customers"
-class="table table-bordered table-striped"
-  datatable
-  [dtTrigger]="dtTrigger"
-  [dtOptions]="dtOptions"
->
-  <thead class="thead-blue">
-    <tr class="d-flex">
-      <th class="col-5 text-center">Customer ID</th>
-      <th class="col-3 text-center">Name</th>
-      <th class="col-4 text-center">Options</th>
-    </tr>
-  </thead>
-  <app-loading-bar *ngIf="(isLoading$ | async)"></app-loading-bar>
-  <tbody *ngIf="((isLoading$ | async) === false)">
-    <tr class="d-flex" *ngFor="let customer of customers">
-      <td class="col-5">{{ customer.id }}</td>
-      <td class="col-3">{{ customer.name }}</td>
-      <td class="col-4 text-center">
-        <button
-          (click)="editCustomer(customer.id)"
-          type="button"
-          class="btn btn-sm btn-primary"
-        >
-          <i class="fa fa-pencil fa-xs"></i>
-        </button>
-        <button
-          data-toggle="modal"
-          data-target="#deleteModal"
-          (click)="openModal(customer)"
-          type="button"
-          class="btn btn-sm btn-danger ml-2"
-        >
-          <i class="fa fa-trash-alt fa-xs"></i>
-        </button>
-      </td>
-    </tr>
-  </tbody>
-</table>
+    *ngIf="customers"
+    class="table table-bordered table-striped mb-0"
+    datatable
+    [dtTrigger]="dtTrigger"
+    [dtOptions]="dtOptions"
+  >
+    <thead class="thead-blue">
+      <tr class="d-flex">
+        <th class="col-5 text-center">Customer ID</th>
+        <th class="col-3 text-center">Name</th>
+        <th class="col-4 text-center">Options</th>
+      </tr>
+    </thead>
+    <app-loading-bar *ngIf="(isLoading$ | async)"></app-loading-bar>
+    <tbody *ngIf="((isLoading$ | async) === false)">
+      <tr class="d-flex" *ngFor="let customer of customers">
+        <td class="col-5 text-break">{{ customer.id }}</td>
+        <td class="col-3 text-break">{{ customer.name }}</td>
+        <td class="col-4 text-center">
+          <button
+            (click)="editCustomer(customer.id)"
+            type="button"
+            class="btn btn-sm btn-primary"
+          >
+            <i class="fa fa-pencil fa-xs"></i>
+          </button>
+          <button
+            data-toggle="modal"
+            data-target="#deleteModal"
+            (click)="openModal(customer)"
+            type="button"
+            class="btn btn-sm btn-danger ml-2"
+          >
+            <i class="fa fa-trash-alt fa-xs"></i>
+          </button>
+        </td>
+      </tr>
+    </tbody>
+  </table>
 </div>
 
 <app-dialog
diff --git a/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.scss b/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.scss
index 9d5a604f4..8b1378917 100644
--- a/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.scss
+++ b/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.scss
@@ -1,4 +1 @@
-.col-3 .col-4 .col-5 {
-  padding: 1rem 0rem 2rem;
-  overflow: hidden;
-}
+

From 0a4c24469aca4cb89ee9c927230327997ec6a976 Mon Sep 17 00:00:00 2001
From: Sandro Castillo <blosomsam@gmail.com>
Date: Fri, 29 Jan 2021 12:09:16 -0500
Subject: [PATCH 4/4] fix: TT-139 delete line white

---
 .../components/customer-list/customer-list.component.scss        | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.scss b/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.scss
index 8b1378917..e69de29bb 100644
--- a/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.scss
+++ b/src/app/modules/customer-management/components/customer-info/components/customer-list/customer-list.component.scss
@@ -1 +0,0 @@
-