From 424ad5f4a110a5b4f4c62ac5c00cb60d0c6f5c66 Mon Sep 17 00:00:00 2001 From: Juan Gabriel Guzman Date: Wed, 13 May 2020 10:58:01 -0500 Subject: [PATCH] style: #222 Removing dead code --- .../technologies/technologies.component.html | 2 +- .../technologies/technologies.component.scss | 2 +- .../technologies.component.spec.ts | 6 +---- .../technologies/technologies.component.ts | 2 +- .../entry-fields.component.spec.ts | 3 +-- .../entry-fields/entry-fields.component.ts | 8 +++---- .../project-list-hover.component.ts | 22 +++++++++---------- 7 files changed, 19 insertions(+), 26 deletions(-) diff --git a/src/app/modules/shared/components/technologies/technologies.component.html b/src/app/modules/shared/components/technologies/technologies.component.html index 735152803..8db025a33 100644 --- a/src/app/modules/shared/components/technologies/technologies.component.html +++ b/src/app/modules/shared/components/technologies/technologies.component.html @@ -1,6 +1,6 @@
- Tecnologias + Technology
{ - type Merged = TechnologyState & ProjectState; let component: TechnologiesComponent; let fixture: ComponentFixture; let store: MockStore; @@ -67,7 +64,6 @@ describe('Technologies component', () => { 'karma', 'github', ]; - console.log(component.selectedTechnologies.length); length = component.selectedTechnologies.length; component.addTechnology(name); expect(component.selectedTechnologies.length).toBe(10); diff --git a/src/app/modules/shared/components/technologies/technologies.component.ts b/src/app/modules/shared/components/technologies/technologies.component.ts index efd6796aa..98a74c8c9 100644 --- a/src/app/modules/shared/components/technologies/technologies.component.ts +++ b/src/app/modules/shared/components/technologies/technologies.component.ts @@ -14,7 +14,7 @@ import {Technology} from '../../models'; export class TechnologiesComponent implements OnInit { private readonly MAX_NUM_TECHNOLOGIES = 10; private readonly MIN_QUERY_LENGTH = 2; - private query = ''; + public query = ''; showList = false; isLoading = false; technology: Technology; diff --git a/src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts b/src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts index 607361d03..13a6d4ba6 100644 --- a/src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts +++ b/src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts @@ -1,5 +1,5 @@ import {async, ComponentFixture, TestBed} from '@angular/core/testing'; -import {provideMockStore, MockStore} from '@ngrx/store/testing'; +import {MockStore, provideMockStore} from '@ngrx/store/testing'; import {FormsModule, ReactiveFormsModule} from '@angular/forms'; import {TechnologyState} from '../../../shared/store/technology.reducers'; @@ -7,7 +7,6 @@ import {allTechnologies} from '../../../shared/store/technology.selectors'; import {EntryFieldsComponent} from './entry-fields.component'; import {ProjectState} from '../../../customer-management/components/projects/components/store/project.reducer'; import {getCustomerProjects} from '../../../customer-management/components/projects/components/store/project.selectors'; -import * as actions from '../../../shared/store/technology.actions'; import * as entryActions from '../../store/entry.actions'; describe('EntryFieldsComponent', () => { diff --git a/src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts b/src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts index 45dbb4d21..25125d997 100644 --- a/src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts +++ b/src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts @@ -1,12 +1,12 @@ import {getActiveTimeEntry} from './../../store/entry.selectors'; -import {Component, OnInit, ViewChild, ElementRef, Renderer2} from '@angular/core'; +import {Component, OnInit} from '@angular/core'; import {FormBuilder, FormGroup} from '@angular/forms'; -import {Store, select} from '@ngrx/store'; +import {select, Store} from '@ngrx/store'; -import {Technology, Activity, NewEntry} from '../../../shared/models'; +import {Activity, NewEntry} from '../../../shared/models'; import {ProjectState} from '../../../customer-management/components/projects/components/store/project.reducer'; import {TechnologyState} from '../../../shared/store/technology.reducers'; -import {LoadActivities, ActivityState, allActivities} from '../../../activities-management/store'; +import {ActivityState, allActivities, LoadActivities} from '../../../activities-management/store'; import * as entryActions from '../../store/entry.actions'; diff --git a/src/app/modules/time-clock/components/project-list-hover/project-list-hover.component.ts b/src/app/modules/time-clock/components/project-list-hover/project-list-hover.component.ts index 341dd2a37..7b3d98d3d 100644 --- a/src/app/modules/time-clock/components/project-list-hover/project-list-hover.component.ts +++ b/src/app/modules/time-clock/components/project-list-hover/project-list-hover.component.ts @@ -1,13 +1,13 @@ -import { getProjects } from './../../../customer-management/components/projects/components/store/project.selectors'; -import { Component, OnInit } from '@angular/core'; -import { Store, select } from '@ngrx/store'; +import {getProjects} from './../../../customer-management/components/projects/components/store/project.selectors'; +import {Component, OnInit} from '@angular/core'; +import {Store, select} from '@ngrx/store'; -import { getActiveTimeEntry } from './../../store/entry.selectors'; -import { Project } from 'src/app/modules/shared/models'; -import { ProjectState } from '../../../customer-management/components/projects/components/store/project.reducer'; +import {getActiveTimeEntry} from './../../store/entry.selectors'; +import {Project} from 'src/app/modules/shared/models'; +import {ProjectState} from '../../../customer-management/components/projects/components/store/project.reducer'; import * as actions from '../../../customer-management/components/projects/components/store/project.actions'; import * as entryActions from '../../store/entry.actions'; -import { ToastrService } from 'ngx-toastr'; +import {ToastrService} from 'ngx-toastr'; @Component({ selector: 'app-project-list-hover', @@ -15,16 +15,14 @@ import { ToastrService } from 'ngx-toastr'; styleUrls: ['./project-list-hover.component.scss'], }) export class ProjectListHoverComponent implements OnInit { - - selectedId: string; listProjects: Project[] = []; - filterProjects = ''; showButton = ''; keyword = 'name'; nameActiveProject: string; activeEntry; - constructor(private store: Store, private toastr: ToastrService) { } + constructor(private store: Store, private toastr: ToastrService) { + } ngOnInit(): void { this.store.dispatch(new actions.LoadProjects()); @@ -59,7 +57,7 @@ export class ProjectListHoverComponent implements OnInit { const entry = {id: this.activeEntry.id, project_id: id}; this.store.dispatch(new entryActions.UpdateActiveEntry(entry)); } else { - const newEntry = { project_id: id, start_date: new Date().toISOString() }; + const newEntry = {project_id: id, start_date: new Date().toISOString()}; this.store.dispatch(new entryActions.CreateEntry(newEntry)); this.toastr.success('You just clocked-in'); }