From c9edc2400be9e91bf3d3e8710bebd415b2541e8e Mon Sep 17 00:00:00 2001
From: Juan Gabriel Guzman <jguzman@ioet.com>
Date: Tue, 23 Jun 2020 07:39:51 -0500
Subject: [PATCH] test: #385 Adding unit tests for restarting entry related
 actions

---
 .../time-clock/store/entry.actions.spec.ts    | 42 ++++++++++++-------
 .../modules/time-clock/store/entry.effects.ts |  2 +-
 .../pages/time-entries.component.html         |  4 +-
 .../pages/time-entries.component.ts           |  1 -
 4 files changed, 30 insertions(+), 19 deletions(-)

diff --git a/src/app/modules/time-clock/store/entry.actions.spec.ts b/src/app/modules/time-clock/store/entry.actions.spec.ts
index 8debb2bb2..54f198bc2 100644
--- a/src/app/modules/time-clock/store/entry.actions.spec.ts
+++ b/src/app/modules/time-clock/store/entry.actions.spec.ts
@@ -1,8 +1,19 @@
 import * as actions from './entry.actions';
 import * as moment from 'moment';
 import { TimeEntriesTimeRange } from '../models/time-entries-time-range';
+import { Entry } from '../../shared/models';
 
 describe('Actions for Entries', () => {
+  let entry: Entry;
+  beforeEach(() => {
+    entry = {
+      id: '1',
+      start_date: new Date(),
+      end_date: new Date(),
+      activity_id: '',
+      technologies: ['abc', 'abc'],
+    };
+  });
 
 
   it('SwitchTimeEntry type is EntryActionTypes.SWITCH_TIME_ENTRY', () => {
@@ -66,13 +77,7 @@ describe('Actions for Entries', () => {
   });
 
   it('UpdateEntrySuccess type is EntryActionTypes.UDPATE_ENTRY_SUCCESS', () => {
-    const updateActiveEntrySuccess = new actions.UpdateEntrySuccess({
-      id: '1',
-      start_date: new Date(),
-      end_date: new Date(),
-      activity_id: '',
-      technologies: ['abc', 'abc'],
-    });
+    const updateActiveEntrySuccess = new actions.UpdateEntrySuccess(entry);
     expect(updateActiveEntrySuccess.type).toEqual(actions.EntryActionTypes.UPDATE_ENTRY_SUCCESS);
   });
 
@@ -82,13 +87,7 @@ describe('Actions for Entries', () => {
   });
 
   it('UpdateActiveEntry type is EntryActionTypes.UDPATE_ENTRY_FAIL', () => {
-    const action = new actions.UpdateEntryRunning({
-        id: '1',
-        start_date: new Date(),
-        end_date: new Date(),
-        activity_id: '',
-        technologies: ['abc', 'abc'],
-      });
+    const action = new actions.UpdateEntryRunning(entry);
     expect(action.type).toEqual(actions.EntryActionTypes.UPDATE_ENTRY_RUNNING);
   });
 
@@ -111,4 +110,19 @@ describe('Actions for Entries', () => {
     const action = new actions.LoadEntriesByTimeRangeFail();
     expect(action.type).toEqual(actions.EntryActionTypes.LOAD_ENTRIES_BY_TIME_RANGE_FAIL);
   });
+
+  it('RestartEntry type is EntryActionTypes.RESTART_ENTRY', () => {
+    const action = new actions.RestartEntry(entry);
+    expect(action.type).toEqual(actions.EntryActionTypes.RESTART_ENTRY);
+  });
+
+  it('RestartEntrySuccess type is EntryActionTypes.RESTART_ENTRY_SUCCESS', () => {
+    const action = new actions.RestartEntrySuccess(entry);
+    expect(action.type).toEqual(actions.EntryActionTypes.RESTART_ENTRY_SUCCESS);
+  });
+
+  it('RestartEntryFail type is EntryActionTypes.RESTART_ENTRY_FAIL', () => {
+    const action = new actions.RestartEntryFail('error');
+    expect(action.type).toEqual(actions.EntryActionTypes.RESTART_ENTRY_FAIL);
+  });
 });
diff --git a/src/app/modules/time-clock/store/entry.effects.ts b/src/app/modules/time-clock/store/entry.effects.ts
index 315e450d4..beddc1f8f 100644
--- a/src/app/modules/time-clock/store/entry.effects.ts
+++ b/src/app/modules/time-clock/store/entry.effects.ts
@@ -209,7 +209,7 @@ export class EntryEffects {
         }),
         catchError((error) => {
           this.toastrService.error( error.error.message, 'This entry could not be restarted');
-          return of(new actions.UpdateEntryFail(error));
+          return of(new actions.RestartEntryFail(error));
         })
       )
     )
diff --git a/src/app/modules/time-entries/pages/time-entries.component.html b/src/app/modules/time-entries/pages/time-entries.component.html
index 93ad8c673..2750771f1 100644
--- a/src/app/modules/time-entries/pages/time-entries.component.html
+++ b/src/app/modules/time-entries/pages/time-entries.component.html
@@ -66,13 +66,11 @@ <h5 class="modal-title" id="exampleModalLongTitle">{{ entryId ? 'Edit Entry' : '
         <app-details-fields
           [entryToEdit]="entry"
           (saveEntry)="saveEntry($event)"
-        >  Active TE: {{activeTimeEntry | json}}
+        >
         </app-details-fields>
       </div>
     </div>
   </div>
-
-  Active TE: {{activeTimeEntry | json}}
 </div>
 
 <app-dialog
diff --git a/src/app/modules/time-entries/pages/time-entries.component.ts b/src/app/modules/time-entries/pages/time-entries.component.ts
index d06029e51..22c717f67 100644
--- a/src/app/modules/time-entries/pages/time-entries.component.ts
+++ b/src/app/modules/time-entries/pages/time-entries.component.ts
@@ -62,7 +62,6 @@ export class TimeEntriesComponent implements OnInit {
   }
 
   doSave(event: SaveEntryEvent) {
-    console.log(event);
     event.entry.start_date = new Date(event.entry.start_date).toISOString();
     if (event.entry.end_date !== null && event.entry.end_date !== undefined) {
       event.entry.end_date = new Date(event.entry.end_date).toISOString();