refactor: TTA-115 unit test for function checkTypeError in status network service

Author: Abigail Cabascango

src/app/modules/shared/services/status-network.service.spec.ts

@@ -25,17 +25,17 @@ describe('StatusNetworkService', () => {
     service = TestBed.inject(StatusNetworkService);
   });
 
-  fit('checkTypeError is error', () => {
+  it('checkTypeError is error', () => {
     const errorType: ErrorType = {error: catchError, message: 'javascript', isError: true};
     spyOn(toastrServiceStub, 'error');
-    service.checkTypeError(errorType)
+    service.checkTypeError(errorType);
     expect(toastrServiceStub.error).toHaveBeenCalled();
   });
 
-  fit('checkTypeError is warning', () => {
+  it('checkTypeError is warning', () => {
     const errorType: ErrorType = {error: catchError, message: 'javascript', isError: false};
     spyOn(toastrServiceStub, 'warning');
-    service.checkTypeError(errorType)
+    service.checkTypeError(errorType);
     expect(toastrServiceStub.warning).toHaveBeenCalled();
   });
 });

src/app/modules/shared/services/status-network.service.ts

@@ -17,17 +17,17 @@ export class StatusNetworkService {
   ) { }
 
   checkTypeError(dataError: ErrorType){
-      const { isError = false, message = 'The server is disconnected', error} = dataError; 
-      const effectiveTypenetwork = navigator.connection;
-      if ((effectiveTypenetwork.effectiveType != '2g')){
-        if(!isError){
-          this.toastrService.warning(message);
-        }
-        if(isError){
-          const errorMessa = error.error && error.error.message? error.error.message: 'There is an error with the server, your request have not be completed';
-          this.toastrService.error(errorMessa);
-        }
+    const { isError = false, message = 'The server is disconnected', error} = dataError;
+    const effectiveTypenetwork = navigator.connection;
+    if ((effectiveTypenetwork.effectiveType !== '2g')){
+      if (!isError){
+        this.toastrService.warning(message);
       }
-      this.toastrService.warning('Your request was not completed, your connection is slow');
+      if (isError){
+        const errorMessa = error.error && error.error.message ? error.error.message : 'There is an error with the server, your request have not be completed';
+        this.toastrService.error(errorMessa);
+      }
+    }
+    this.toastrService.warning('Your request was not completed, your connection is slow');
   }
 }