Skip to content

Commit f8d3db3

Browse files
committed
fix: TT-178 Make URI clickable when possible
1 parent 75d6105 commit f8d3db3

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

src/app/modules/reports/components/time-entries-table/time-entries-table.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
</thead>
2222
<app-loading-bar *ngIf="dataSource.isLoading"></app-loading-bar>
2323
<tbody *ngIf="!dataSource.isLoading">
24-
<tr class="d-flex" *ngFor="let entry of dataSource.data" _nghost-c0="">
24+
<tr class="d-flex" *ngFor="let entry of dataSource.data">
2525
<td class="hidden-col">{{ entry.id }}</td>
2626
<td class="col md-col">{{ entry.owner_email }}</td>
2727
<td class="col sm-col">

src/app/modules/reports/components/time-entries-table/time-entries-table.component.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ describe('Reports Page', () => {
7979
fit('when the uri starts with http or https it should return true and open the url in a new tab', () => {
8080
const uriExpected = 'http://customuri.com';
8181
spyOn(window, 'open');
82-
// TODO: test te objet windows.open spyOnProperty(window, 'open').and.returnValue(true);
8382
const isValidUri = uriExpected.startsWith('http' || 'https');
8483
expect(isValidUri).toBeTrue();
8584
expect(window.open).toHaveBeenCalled();

src/app/modules/reports/components/time-entries-table/time-entries-table.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import * as moment from 'moment';
66
import { Observable, Subject } from 'rxjs';
77
import { Entry } from 'src/app/modules/shared/models';
88
import { DataSource } from 'src/app/modules/shared/models/data-source.model';
9-
109
import { EntryState } from '../../../time-clock/store/entry.reducer';
1110
import { getReportDataSource } from '../../../time-clock/store/entry.selectors';
1211

@@ -94,4 +93,5 @@ export class TimeEntriesTableComponent implements OnInit, OnDestroy, AfterViewIn
9493
isValidUri(uri: string) {
9594
return uri.startsWith('http' || 'https');
9695
}
96+
9797
}

0 commit comments

Comments
 (0)