Skip to content

Commit dba661e

Browse files
author
Juan Gabriel Guzman
committed
style: #228 Removing some warnings on console when running unit tests
1 parent eac05a8 commit dba661e

File tree

4 files changed

+30
-23
lines changed

4 files changed

+30
-23
lines changed

karma.conf.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ module.exports = function (config) {
88
plugins: [
99
require('karma-jasmine'),
1010
require('karma-chrome-launcher'),
11-
require('karma-jasmine-html-reporter'),
12-
require('karma-coverage-istanbul-reporter'),
1311
require('@angular-devkit/build-angular/plugins/karma'),
14-
require('karma-spec-reporter')
12+
require('karma-spec-reporter'),
13+
require('karma-coverage-istanbul-reporter')
14+
1515
],
1616
client: {
1717
clearContext: false // leave Jasmine Spec Runner output visible in browser
@@ -27,14 +27,14 @@ module.exports = function (config) {
2727
functions: 80
2828
}
2929
},
30-
reporters: ['spec', 'kjhtml'],
30+
reporters: ['spec'],
3131
specReporter: {
32-
maxLogLines: 5, // limit number of lines logged per test
33-
suppressErrorSummary: true, // do not print error summary
34-
suppressFailed: false, // do not print information about failed tests
35-
suppressPassed: false, // do not print information about passed tests
36-
suppressSkipped: true, // do not print information about skipped tests
37-
showSpecTiming: false // print the time elapsed for each spec
32+
maxLogLines: 5,
33+
suppressErrorSummary: false,
34+
suppressFailed: false,
35+
suppressPassed: false,
36+
suppressSkipped: true,
37+
showSpecTiming: false
3838
},
3939

4040
port: 9876,

src/app/modules/shared/components/user/user.component.spec.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { async, ComponentFixture, TestBed } from '@angular/core/testing';
22
import { of } from 'rxjs';
33
import { UserComponent } from './user.component';
44
import { AzureAdB2CService } from '../../../login/services/azure.ad.b2c.service';
5+
import {AppRoutingModule} from '../../../../app-routing.module';
56

67
describe('UserComponent', () => {
78
let component: UserComponent;
@@ -20,6 +21,7 @@ describe('UserComponent', () => {
2021
beforeEach(async(() => {
2122
TestBed.configureTestingModule({
2223
declarations: [UserComponent],
24+
imports: [AppRoutingModule],
2325
providers: [{ providers: AzureAdB2CService, useValue: azureAdB2CServiceStub }],
2426
}).compileComponents();
2527
}));

src/app/modules/time-clock/components/project-list-hover/project-list-hover.component.spec.ts

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
1-
import { FormBuilder } from '@angular/forms';
2-
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
3-
import { provideMockStore, MockStore } from '@ngrx/store/testing';
4-
import { HttpClientTestingModule } from '@angular/common/http/testing';
1+
import {FormBuilder} from '@angular/forms';
2+
import {async, ComponentFixture, TestBed} from '@angular/core/testing';
3+
import {provideMockStore, MockStore} from '@ngrx/store/testing';
4+
import {HttpClientTestingModule} from '@angular/common/http/testing';
55

6-
import { ProjectListHoverComponent } from './project-list-hover.component';
7-
import { ProjectState } from '../../../customer-management/components/projects/components/store/project.reducer';
8-
import { getCustomerProjects } from '../../../customer-management/components/projects/components/store/project.selectors';
9-
import { FilterProjectPipe } from '../../../shared/pipes';
10-
import { CreateEntry, UpdateActiveEntry } from '../../store/entry.actions';
6+
import {ProjectListHoverComponent} from './project-list-hover.component';
7+
import {ProjectState} from '../../../customer-management/components/projects/components/store/project.reducer';
8+
import {getCustomerProjects} from '../../../customer-management/components/projects/components/store/project.selectors';
9+
import {FilterProjectPipe} from '../../../shared/pipes';
10+
import {CreateEntry, UpdateActiveEntry} from '../../store/entry.actions';
11+
import {AutocompleteLibModule} from 'angular-ng-autocomplete';
1112

1213
describe('ProjectListHoverComponent', () => {
1314
let component: ProjectListHoverComponent;
@@ -18,7 +19,7 @@ describe('ProjectListHoverComponent', () => {
1819
const state = {
1920
projects: {
2021
projects: [],
21-
customerProjects: [{ id: 'id', name: 'name', description: 'description', project_type_id: '123' }],
22+
customerProjects: [{id: 'id', name: 'name', description: 'description', project_type_id: '123'}],
2223
isLoading: false,
2324
message: '',
2425
projectToEdit: undefined,
@@ -38,8 +39,8 @@ describe('ProjectListHoverComponent', () => {
3839
beforeEach(async(() => {
3940
TestBed.configureTestingModule({
4041
declarations: [ProjectListHoverComponent, FilterProjectPipe],
41-
providers: [FormBuilder, provideMockStore({ initialState: state })],
42-
imports: [HttpClientTestingModule],
42+
providers: [FormBuilder, provideMockStore({initialState: state})],
43+
imports: [HttpClientTestingModule, AutocompleteLibModule],
4344
}).compileComponents();
4445
store = TestBed.inject(MockStore);
4546
mockProjectsSelector = store.overrideSelector(getCustomerProjects, state.projects);
@@ -65,7 +66,7 @@ describe('ProjectListHoverComponent', () => {
6566
});
6667

6768
it('dispatchs a UpdateEntry action when activeEntry is not null', () => {
68-
const entry = { id: '123', project_id: 'p1', start_date: new Date().toISOString() };
69+
const entry = {id: '123', project_id: 'p1', start_date: new Date().toISOString()};
6970
component.activeEntry = entry;
7071
spyOn(store, 'dispatch');
7172

src/app/modules/time-entries/pages/time-entries.component.spec.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ import { getProjects } from '../../customer-management/components/projects/compo
1616
import { EntryState } from '../../time-clock/store/entry.reducer';
1717
import { allEntries } from '../../time-clock/store/entry.selectors';
1818
import * as entryActions from '../../time-clock/store/entry.actions';
19+
import {TechnologiesComponent} from '../../shared/components/technologies/technologies.component';
20+
import {TimeEntriesSummaryComponent} from '../../time-clock/components/time-entries-summary/time-entries-summary.component';
1921

2022
describe('TimeEntriesComponent', () => {
2123
type Merged = TechnologyState & ProjectState & EntryState;
@@ -67,6 +69,8 @@ describe('TimeEntriesComponent', () => {
6769
GroupByDatePipe,
6870
MonthPickerComponent,
6971
TimeEntriesComponent,
72+
TechnologiesComponent,
73+
TimeEntriesSummaryComponent
7074
],
7175
providers: [provideMockStore({ initialState: state })],
7276
imports: [FormsModule, ReactiveFormsModule],

0 commit comments

Comments
 (0)