Skip to content

Commit d91462b

Browse files
Merge 88dfdfb into 85ab09a
2 parents 85ab09a + 88dfdfb commit d91462b

File tree

7 files changed

+18
-11
lines changed

7 files changed

+18
-11
lines changed

src/app/modules/login/login.component.spec.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,12 +89,14 @@ describe('LoginComponent', () => {
8989
spyOn(azureAdB2CService, 'isLogin').and.returnValue(false);
9090
spyOn(azureAdB2CService, 'setCookies').and.returnValue();
9191
spyOn(azureAdB2CService, 'signIn').and.returnValue(of(() => {}));
92+
spyOn(azureAdB2CService, 'getUserId').and.returnValue('userId_123');
9293
spyOn(featureToggleCookiesService, 'setCookies').and.returnValue(featureToggleCookiesService.setCookies());
9394

9495
component.login();
9596

9697
expect(azureAdB2CService.signIn).toHaveBeenCalled();
9798
expect(azureAdB2CService.setCookies).toHaveBeenCalled();
99+
expect(azureAdB2CService.getUserId).toHaveBeenCalled();
98100
expect(featureToggleCookiesService.setCookies).toHaveBeenCalled();
99101
}));
100102

src/app/modules/shared/components/details-fields/details-fields.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
formControlName="uri"
6565
id="uri"
6666
type="text"
67-
placeholder="Enter Jira ticket URL"
67+
placeholder="Enter your ticket number"
6868
class="url-ticket-input form-control"
6969
aria-label="Small"
7070
aria-describedby="inputGroup-sizing-sm"

src/app/modules/shared/components/details-fields/details-fields.component.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,8 @@ describe('DetailsFieldsComponent', () => {
208208

209209
it('on cleanFieldsForm the project_id and project_name should be kept', () => {
210210
const entryFormValueExpected = {
211-
...formValues,
211+
project_id: '',
212+
project_name: '',
212213
activity_id: '',
213214
uri: '',
214215
start_date: formatDate(new Date(), DATE_FORMAT, 'en'),

src/app/modules/shared/components/details-fields/details-fields.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ export class DetailsFieldsComponent implements OnChanges, OnInit {
235235
}
236236

237237
cleanFieldsForm(): void {
238-
this.cleanForm(true);
238+
this.cleanForm(false);
239239
}
240240

241241
selectActiveActivities() {

src/app/modules/time-clock/components/entry-fields/entry-fields.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@
1313
</div>
1414

1515
<div class="form-group">
16-
<label>Ticket URI:</label>
16+
<label>Ticket Number:</label>
1717
<input
1818
(blur)="onSubmit()"
1919
type="text"
20-
placeholder="Enter Jira ticket URL"
20+
placeholder="Enter your ticker number"
2121
id="uri"
2222
formControlName="uri"
2323
class="url-ticket-input form-control"

src/app/modules/time-entries/pages/time-entries.component.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
<th class="col">Customer</th>
3434
<th class="col">Project</th>
3535
<th class="col">Activity</th>
36-
<th class="col"></th>
36+
<th class="col">Actions</th>
3737
</tr>
3838
</thead>
3939
<app-loading-bar *ngIf="dataSource.isLoading"></app-loading-bar>
@@ -45,13 +45,13 @@
4545
<td class="col">{{ entry.customer_name }}</td>
4646
<td class="col">{{ entry.project_name }}</td>
4747
<td class="col">{{ entry.activity_name }}</td>
48-
<td class="col">
48+
<td class="col actions-buttons">
4949
<button class="btn btn-sm btn-primary" data-toggle="modal" data-target="#editRecordsByDate" (click)="editEntry(entry.id)">
50-
<i class="fa fa-edit fa-xs"></i>
51-
</button>
50+
<i class="fa fa-edit fa-xs"></i>
51+
</button>
5252
<button class="btn btn-sm btn-danger ml-2" data-toggle="modal" data-target="#deleteModal" (click)="openModal(entry)">
53-
<i class="fa fa-trash fa-xs"></i>
54-
</button>
53+
<i class="fa fa-trash fa-xs"></i>
54+
</button>
5555
</td>
5656
</tr>
5757
</tbody>

src/app/modules/time-entries/pages/time-entries.component.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,3 +26,7 @@ table.dataTable thead .sorting_asc,
2626
table.dataTable thead .sorting_desc {
2727
background-image: none;
2828
}
29+
30+
.actions-buttons {
31+
text-align: center;
32+
}

0 commit comments

Comments
 (0)