Skip to content

Commit d6c4865

Browse files
committed
refactor test TimeEntriesTableComponent
1 parent 835d03c commit d6c4865

File tree

2 files changed

+3
-18
lines changed

2 files changed

+3
-18
lines changed

src/app/modules/reports/components/time-entries-table/time-entries-table.component.spec.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ describe('Reports Page', () => {
1717
let fixture: ComponentFixture<TimeEntriesTableComponent>;
1818
let store: MockStore<EntryState>;
1919
let getReportDataSourceSelectorMock;
20-
let getResultSumEntriesSelectedMock;
2120
let durationTime: number;
2221
let row: number;
2322
let node: number;
@@ -96,8 +95,8 @@ describe('Reports Page', () => {
9695
component = fixture.componentInstance;
9796
store = TestBed.inject(MockStore);
9897
store.setState(state);
99-
getReportDataSourceSelectorMock = store.overrideSelector(getReportDataSource, state.reportDataSource);
100-
getResultSumEntriesSelectedMock = store.overrideSelector(getResultSumEntriesSelected, state.resultSumEntriesSelected);
98+
getReportDataSourceSelectorMock = (store.overrideSelector(getReportDataSource, state.reportDataSource),
99+
store.overrideSelector(getResultSumEntriesSelected, state.resultSumEntriesSelected));
101100
fixture.detectChanges();
102101
}
103102
);
@@ -212,7 +211,7 @@ describe('Reports Page', () => {
212211

213212
it('the sume of hours of entries selected is equal to {hours:0, minutes:0, seconds:0}', () => {
214213
let checked = true;
215-
let{hours, minutes, seconds}:TotalHours = component.sumHoursEntriesSelected(timeEntryList[0], checked);
214+
let {hours, minutes, seconds}:TotalHours = component.sumHoursEntriesSelected(timeEntryList[0], checked);
216215
checked = false;
217216
({hours, minutes,seconds} = component.sumHoursEntriesSelected(timeEntryList[0], checked));
218217
expect({hours, minutes, seconds}).toEqual({hours:0, minutes:0, seconds:0});

src/app/modules/shared/components/details-fields/details-fields.component.spec.ts

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -715,20 +715,6 @@ describe('DetailsFieldsComponent', () => {
715715
expect(component.entryForm.value.project_name).toBe('name');
716716
});
717717

718-
it('it calls the close method if opened equals true', () => {
719-
const datepicker: any = { opened : true, open : () => ({}), close : () => ({}) };
720-
spyOn(datepicker, 'close');
721-
component.openOrCloseDatePicker(datepicker);
722-
expect(datepicker.close).toHaveBeenCalled();
723-
});
724-
725-
it('it calls the open method if opened equals false', () => {
726-
const datepicker: any = { opened : false, open : () => ({}), close : () => ({}) };
727-
spyOn(datepicker, 'open');
728-
component.openOrCloseDatePicker(datepicker);
729-
expect(datepicker.open).toHaveBeenCalled();
730-
});
731-
732718
/*
733719
TODO As part of https://github.com/ioet/time-tracker-ui/issues/424 a new parameter was added to the details-field-component,
734720
and now these couple of tests are failing. A solution to this error might be generate a Test Wrapper Component. More details here:

0 commit comments

Comments
 (0)