fix: TT-25 Empty selection in Activity drop-down(Time Clock page)

Author: lenshinoda

src/app/modules/time-clock/components/entry-fields/entry-fields.component.html

@@ -5,7 +5,7 @@
       (change)="onSubmit()"
       class="form-control"
       formControlName="activity_id"
-      [class.is-invalid]="activity_id.invalid && activity_id.touched"
+      [class.is-invalid]="activity_id.invalid && activity_id.touched || activity_id.value == '-1'"
       required>
       <option value="-1"></option>
       <option *ngFor="let activity of activities" value="{{ activity.id }}">{{ activity.name }}</option>

src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts

@@ -18,6 +18,7 @@ import { DATE_FORMAT_YEAR } from 'src/environments/environment';
 import { FeatureManagerService } from './../../../shared/feature-toggles/feature-toggle-manager.service';
 import { FeatureToggleGeneralService } from './../../../shared/feature-toggles/feature-toggle-general/feature-toggle-general.service';
 import { FeatureToggle } from 'src/environments/enum';
+import { By } from '@angular/platform-browser';
 
 
 describe('EntryFieldsComponent', () => {
@@ -466,6 +467,15 @@ describe('EntryFieldsComponent', () => {
       expect(featureToggleGeneralService.isActivated).toHaveBeenCalled();
     });
   });
+
+  it('toastrService should be called when the activity field is empty', () => {
+    fixture.detectChanges();
+    const select: HTMLSelectElement = fixture.debugElement.query(By.css('select')).nativeElement;
+    spyOn(toastrServiceStub, 'error');
+    select.value = select.options[0].value;
+    select.dispatchEvent(new Event('change'));
+    expect(toastrServiceStub.error).toHaveBeenCalled();
+  });
 });
 
 

src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts

@@ -133,6 +133,10 @@ export class EntryFieldsComponent implements OnInit, OnDestroy {
   }
 
   onSubmit() {
+    if (this.entryForm.value.activity_id === '-1') {
+      this.toastrService.error('Please enter a valid activity');
+      return;
+    }
     this.store.dispatch(new entryActions.UpdateEntryRunning({ ...this.newData, ...this.entryForm.value }));
   }