primer commit

Author: jisazac

src/app/modules/time-clock/services/entry.service.spec.ts

@@ -84,15 +84,15 @@ describe('EntryService', () => {
   });
 
   it('stops an entry using POST', () => {
-    service.urlInProduction = true;
+    service.urlInProductionLegacy = true;
     service.stopEntryRunning('id').subscribe();
 
     const updateEntryRequest = httpMock.expectOne(`${service.baseUrl}/id/stop`);
     expect(updateEntryRequest.request.method).toBe('POST');
   });
 
   it('stops an entry using PUT', () => {
-    service.urlInProduction = false;
+    service.urlInProductionLegacy = false;
     service.stopEntryRunning('id').subscribe();
 
     const updateEntryRequest = httpMock.expectOne(`${service.baseUrl}/stop`);
@@ -105,7 +105,7 @@ describe('EntryService', () => {
     const pipe: DatePipe = new DatePipe('en');
     const timeRange: TimeEntriesTimeRange = {start_date: yesterday, end_date: today};
     const userId = '123';
-    const reportsUrl = service.urlInProduction ? service.baseUrl : service.baseUrl + '/report';
+    const reportsUrl = service.urlInProductionLegacy ? service.baseUrl : service.baseUrl + '/report';
     service.loadEntriesByTimeRange(timeRange, userId).subscribe();
 
     const loadEntryRequest = httpMock.expectOne(req => req.method === 'GET' && req.url === reportsUrl);
@@ -120,7 +120,7 @@ describe('EntryService', () => {
     const today = moment(new Date());
     const timeRange: TimeEntriesTimeRange = { start_date: yesterday, end_date: today };
     const userId = '123';
-    const reportsUrl = service.urlInProduction ? service.baseUrl : service.baseUrl + '/report';
+    const reportsUrl = service.urlInProductionLegacy ? service.baseUrl : service.baseUrl + '/report';
     service.loadEntriesByTimeRange(timeRange, userId).subscribe();
 
     const loadEntryRequest = httpMock.expectOne(req => req.method === 'GET' && req.url === reportsUrl);
@@ -132,7 +132,7 @@ describe('EntryService', () => {
     const today = moment(new Date());
     const timeRange: TimeEntriesTimeRange = { start_date: yesterday, end_date: today };
     const userId = '123';
-    const reportsUrl = service.urlInProduction ? service.baseUrl : service.baseUrl + '/report';
+    const reportsUrl = service.urlInProductionLegacy ? service.baseUrl : service.baseUrl + '/report';
 
     service.loadEntriesByTimeRange(timeRange, userId).subscribe();
 

src/app/modules/time-clock/services/entry.service.ts

@@ -20,7 +20,7 @@ export class EntryService {
 
   static TIME_ENTRIES_DATE_TIME_FORMAT = 'yyyy-MM-ddTHH:mm:ssZZZZZ';
   baseUrl = `${environment.timeTrackerApiUrl}/time-entries`;
-  urlInProduction = environment.production === EnvironmentType.TT_PROD || environment.production === EnvironmentType.TT_PROD_LEGACY;
+  urlInProductionLegacy = environment.production === EnvironmentType.TT_PROD_LEGACY;
 
   loadActiveEntry(): Observable<any> {
     return this.http.get(`${this.baseUrl}/running`);
@@ -46,7 +46,7 @@ export class EntryService {
   }
 
   stopEntryRunning(idEntry: string): Observable<any> {
-    return (this.urlInProduction ? this.http.post(`${this.baseUrl}/${idEntry}/stop`, null) : this.http.put(`${this.baseUrl}/stop`, null) );
+    return (this.urlInProductionLegacy ? this.http.post(`${this.baseUrl}/${idEntry}/stop`, null) : this.http.put(`${this.baseUrl}/stop`, null) );
   }
 
   restartEntry(idEntry: string): Observable<Entry> {
@@ -69,7 +69,7 @@ export class EntryService {
 
   loadEntriesByTimeRange(range: TimeEntriesTimeRange, userId: string): Observable<any> {
     const MAX_NUMBER_OF_ENTRIES_FOR_REPORTS = 9999;
-    const loadEntriesByTimeRangeURL = this.urlInProduction ? this.baseUrl : this.baseUrl + '/report';
+    const loadEntriesByTimeRangeURL = this.urlInProductionLegacy ? this.baseUrl : this.baseUrl + '/report';
     return this.http.get(loadEntriesByTimeRangeURL,
       {
         params: {

src/app/modules/users/services/users.service.spec.ts

@@ -35,7 +35,7 @@ describe('UsersService', () => {
   it('grant role to a User', () => {
     const userId = 'userId';
     const roleId = 'admin';
-    service.isProduction = true;
+    service.isProductionLegacy = true;
 
     service.grantRole(userId, roleId).subscribe();
 
@@ -46,7 +46,7 @@ describe('UsersService', () => {
   it('grant role to a User locally', () => {
     const userId = 'userId';
     const roleId = 'admin';
-    service.isProduction = false;
+    service.isProductionLegacy = false;
 
     service.grantRole(userId, roleId).subscribe();
 
@@ -57,7 +57,7 @@ describe('UsersService', () => {
   it('revoke role to a User', () => {
     const userId = 'userId';
     const roleId = 'admin';
-    service.isProduction = true;
+    service.isProductionLegacy = true;
 
     service.revokeRole(userId, roleId).subscribe();
 
@@ -68,7 +68,7 @@ describe('UsersService', () => {
   it('revoke role to a User locally', () => {
     const userId = 'userId';
     const roleId = 'admin';
-    service.isProduction = false;
+    service.isProductionLegacy = false;
 
     service.revokeRole(userId, roleId).subscribe();
 

src/app/modules/users/services/users.service.ts

@@ -9,7 +9,7 @@ import { EnvironmentType } from './../../../../environments/enum';
   providedIn: 'root',
 })
 export class UsersService {
-  isProduction = environment.production === EnvironmentType.TT_PROD || environment.production === EnvironmentType.TT_PROD_LEGACY;
+  isProductionLegacy = environment.production === EnvironmentType.TT_PROD_LEGACY;
   constructor(private http: HttpClient) {}
 
   baseUrl = `${environment.timeTrackerApiUrl}/users`;
@@ -19,13 +19,13 @@ export class UsersService {
   }
 
   grantRole(userId: string, roleId: string): Observable<any> {
-    const url = this.isProduction ? `${this.baseUrl}/${userId}/roles/${roleId}/grant`
+    const url = this.isProductionLegacy ? `${this.baseUrl}/${userId}/roles/${roleId}/grant`
     : `${this.baseUrl}/${userId}/${roleId}/grant`;
     return this.http.post(url, null);
   }
 
   revokeRole(userId: string, roleId: string): Observable<any> {
-    const url = this.isProduction ? `${this.baseUrl}/${userId}/roles/${roleId}/revoke`
+    const url = this.isProductionLegacy ? `${this.baseUrl}/${userId}/roles/${roleId}/revoke`
     : `${this.baseUrl}/${userId}/${roleId}/revoke`;
     return this.http.post(url, null);
   }