test: TTL-910 update tests

Author: Santiago220991

src/app/modules/reports/components/time-range-custom/time-range-custom.component.spec.ts

@@ -8,15 +8,14 @@ import * as entryActions from '../../../time-clock/store/entry.actions';
 import * as moment from 'moment';
 import { SimpleChange } from '@angular/core';
 
-
 describe('TimeRangeCustomComponent', () => {
   let component: TimeRangeCustomComponent;
   let fixture: ComponentFixture<TimeRangeCustomComponent>;
   let store: MockStore<EntryState>;
   const toastrServiceStub = {
     error: () => {
       return 'test error';
-    }
+    },
   };
 
   const timeEntry = {
@@ -27,7 +26,7 @@ describe('TimeRangeCustomComponent', () => {
     technologies: ['react', 'redux'],
     comments: 'any comment',
     uri: 'TT-123',
-    project_id: '1'
+    project_id: '1',
   };
 
   const state = {
@@ -44,13 +43,9 @@ describe('TimeRangeCustomComponent', () => {
   beforeEach(async () => {
     await TestBed.configureTestingModule({
       imports: [FormsModule, ReactiveFormsModule],
-      declarations: [ TimeRangeCustomComponent ],
-      providers: [
-        provideMockStore({ initialState: state }),
-        { provide: ToastrService, useValue: toastrServiceStub }
-      ],
-    })
-    .compileComponents();
+      declarations: [TimeRangeCustomComponent],
+      providers: [provideMockStore({ initialState: state }), { provide: ToastrService, useValue: toastrServiceStub }],
+    }).compileComponents();
     store = TestBed.inject(MockStore);
   });
 
@@ -81,10 +76,12 @@ describe('TimeRangeCustomComponent', () => {
 
     component.onSubmit();
 
-    expect(store.dispatch).toHaveBeenCalledWith(new entryActions.LoadEntriesByTimeRange({
-      start_date: end.startOf('day'),
-      end_date: start.endOf('day')
-    }));
+    expect(store.dispatch).toHaveBeenCalledWith(
+      new entryActions.LoadEntriesByTimeRange({
+        start_date: end.startOf('day'),
+        end_date: start.endOf('day'),
+      })
+    );
   });
 
   it('shows an error when the end date is before the start date', () => {
@@ -108,7 +105,6 @@ describe('TimeRangeCustomComponent', () => {
 
     expect(component.range.controls.start.setValue).toHaveBeenCalled();
     expect(component.range.controls.end.setValue).toHaveBeenCalled();
-
   });
 
   it('triggers onSubmit to set initial data', () => {
@@ -121,30 +117,41 @@ describe('TimeRangeCustomComponent', () => {
 
   it('When the ngOnChanges method is called, the onSubmit method is called', () => {
     const userIdCalled = 'test-user-1';
+    const projectIdCalled = 'test-project';
+    const activityIdCalled = 'test-activity';
     spyOn(component, 'onSubmit');
 
-    component.ngOnChanges({userId: new SimpleChange(null, userIdCalled, false)});
+    component.ngOnChanges({
+      userId: new SimpleChange(null, userIdCalled, false),
+      projectId: new SimpleChange(null, projectIdCalled, false),
+      activityId: new SimpleChange(null, activityIdCalled, false),
+    });
 
     expect(component.onSubmit).toHaveBeenCalled();
   });
 
   it('When the ngOnChanges method is the first change, the onSubmit method is not called', () => {
     const userIdNotCalled = 'test-user-2';
+    const projectIdNotCalled = 'test-project';
+    const activityIdNotCalled = 'test-activity';
     spyOn(component, 'onSubmit');
 
-    component.ngOnChanges({userId: new SimpleChange(null, userIdNotCalled, true)});
+    component.ngOnChanges({
+      userId: new SimpleChange(null, userIdNotCalled, true),
+      projectId: new SimpleChange(null, projectIdNotCalled, true),
+      activityId: new SimpleChange(null, activityIdNotCalled, true),
+    });
 
     expect(component.onSubmit).not.toHaveBeenCalled();
   });
 
   it('should call range form and delete variable local storage ', () => {
     spyOn(localStorage, 'removeItem').withArgs('rangeDatePicker');
-    component.range.setValue({start: null, end: null});
+    component.range.setValue({ start: null, end: null });
     jasmine.clock().install();
     component.dateRangeChange();
     jasmine.clock().tick(200);
     expect(localStorage.removeItem).toHaveBeenCalledWith('rangeDatePicker');
     jasmine.clock().uninstall();
   });
-
 });

src/app/modules/reports/components/time-range-form/time-range.component.spec.ts

@@ -17,7 +17,7 @@ describe('Reports Page', () => {
     let store: MockStore<EntryState>;
 
     const toastrServiceStub = {
-      error: (message?: string, title?: string, override?: Partial<IndividualConfig>) => { }
+      error: (message?: string, title?: string, override?: Partial<IndividualConfig>) => {},
     };
 
     const timeEntry = {
@@ -28,7 +28,7 @@ describe('Reports Page', () => {
       technologies: ['react', 'redux'],
       comments: 'any comment',
       uri: 'custom uri',
-      project_id: '123'
+      project_id: '123',
     };
 
     const state = {
@@ -42,18 +42,20 @@ describe('Reports Page', () => {
       entriesForReport: [timeEntry],
     };
 
-    beforeEach(waitForAsync(() => {
-      TestBed.configureTestingModule({
-        imports: [FormsModule, ReactiveFormsModule],
-        declarations: [TimeRangeFormComponent, InputDateComponent],
-        providers: [
-          provideMockStore({ initialState: state }),
-          { provide: ToastrService, useValue: toastrServiceStub },
-          { provide: DateAdapter, useClass: DateAdapter }
-        ],
-      }).compileComponents();
-      store = TestBed.inject(MockStore);
-    }));
+    beforeEach(
+      waitForAsync(() => {
+        TestBed.configureTestingModule({
+          imports: [FormsModule, ReactiveFormsModule],
+          declarations: [TimeRangeFormComponent, InputDateComponent],
+          providers: [
+            provideMockStore({ initialState: state }),
+            { provide: ToastrService, useValue: toastrServiceStub },
+            { provide: DateAdapter, useClass: DateAdapter },
+          ],
+        }).compileComponents();
+        store = TestBed.inject(MockStore);
+      })
+    );
 
     beforeEach(() => {
       fixture = TestBed.createComponent(TimeRangeFormComponent);
@@ -74,10 +76,12 @@ describe('Reports Page', () => {
 
       component.onSubmit();
 
-      expect(store.dispatch).toHaveBeenCalledWith(new entryActions.LoadEntriesByTimeRange({
-        start_date: yesterday.startOf('day'),
-        end_date: today.endOf('day')
-      }));
+      expect(store.dispatch).toHaveBeenCalledWith(
+        new entryActions.LoadEntriesByTimeRange({
+          start_date: yesterday.startOf('day'),
+          end_date: today.endOf('day'),
+        })
+      );
     });
 
     it('setInitialDataOnScreen on ngOnInit', () => {
@@ -128,19 +132,31 @@ describe('Reports Page', () => {
     });
 
     it('When the ngOnChanges method is called, the onSubmit method is called', () => {
-      const userId = 'abcd';
+      const userIdCalled = 'test-user-2';
+      const projectIdCalled = 'test-project';
+      const activityIdCalled = 'test-activity';
       spyOn(component, 'onSubmit');
 
-      component.ngOnChanges({userId: new SimpleChange(null, userId, false)});
+      component.ngOnChanges({
+        userId: new SimpleChange(null, userIdCalled, false),
+        projectId: new SimpleChange(null, projectIdCalled, false),
+        activityId: new SimpleChange(null, activityIdCalled, false),
+      });
 
       expect(component.onSubmit).toHaveBeenCalled();
     });
 
     it('When the ngOnChanges method is the first change, the onSubmit method is not called', () => {
-      const userId = 'abcd';
+      const userIdNotCalled = 'test-user-2';
+      const projectIdNotCalled = 'test-project';
+      const activityIdNotCalled = 'test-activity';
       spyOn(component, 'onSubmit');
 
-      component.ngOnChanges({userId: new SimpleChange(null, userId, true)});
+      component.ngOnChanges({
+        userId: new SimpleChange(null, userIdNotCalled, true),
+        projectId: new SimpleChange(null, projectIdNotCalled, true),
+        activityId: new SimpleChange(null, activityIdNotCalled, true),
+      });
 
       expect(component.onSubmit).not.toHaveBeenCalled();
     });