refactor: TTL-887 import constants from a shared file

Author: Santiago220991

src/app/modules/shared/components/details-fields/details-fields.component.ts

@@ -27,10 +27,8 @@ import { DATE_FORMAT, DATE_FORMAT_YEAR } from 'src/environments/environment';
 import { TechnologiesComponent } from '../technologies/technologies.component';
 import { MatDatepicker } from '@angular/material/datepicker';
 import { Observable } from 'rxjs';
-
-const INTERNAL_APP_STRING = 'ioet';
-const PROJECT_NAME_TO_SKIP = ['English Lessons', 'Safari Books'];
-const EMPTY_FIELDS_ERROR_MESSAGE = 'Make sure to add a description and/or ticket number when working on an internal app.';
+import { EMPTY_FIELDS_ERROR_MESSAGE } from '../../messages';
+import { INTERNAL_APP_STRING, PROJECT_NAME_TO_SKIP } from 'src/app/modules/shared/internal-app-constants';
 
 type Merged = TechnologyState & ProjectState & ActivityState & EntryState;
 @Component({
@@ -122,8 +120,8 @@ export class DetailsFieldsComponent implements OnChanges, OnInit {
       });
   }
 
-  onClearedComponent({term}) {
-    const isSearchEmpty = (term === '');
+  onClearedComponent({ term }) {
+    const isSearchEmpty = term === '';
     if (isSearchEmpty) {
       this.isTechnologiesDisabled = true;
       this.entryForm.patchValue({
@@ -172,7 +170,7 @@ export class DetailsFieldsComponent implements OnChanges, OnInit {
           projectWithSearchField.search_field = `${project.customer.name} - ${project.name}`;
           this.listRecentProjects.push(projectWithSearchField);
         });
-      }else{
+      } else {
         this.listRecentProjects = this.listProjects;
       }
       this.listProjectsShowed = this.listRecentProjects;
@@ -335,7 +333,6 @@ export class DetailsFieldsComponent implements OnChanges, OnInit {
   }
 
   onSubmit() {
-
     const emptyValue = '';
     const { project_name, uri, description } = this.entryForm.value;
     const areEmptyValues = [uri, description].every(item => item === emptyValue);

src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts

@@ -16,11 +16,8 @@ import { formatDate } from '@angular/common';
 import { getTimeEntriesDataSource } from '../../store/entry.selectors';
 import { DATE_FORMAT } from 'src/environments/environment';
 import { Subscription } from 'rxjs';
-
-
-const INTERNAL_APP_STRING = 'ioet';
-const PROJECT_NAME_TO_SKIP = ['English Lessons', 'Safari Books'];
-const EMPTY_FIELDS_ERROR_MESSAGE = 'Make sure to add a description and/or ticket number when working on an internal app.';
+import { EMPTY_FIELDS_ERROR_MESSAGE } from 'src/app/modules/shared/messages';
+import { INTERNAL_APP_STRING, PROJECT_NAME_TO_SKIP } from 'src/app/modules/shared/internal-app-constants';
 
 type Merged = TechnologyState & ProjectState & ActivityState;
 
@@ -144,7 +141,6 @@ export class EntryFieldsComponent implements OnInit, OnDestroy {
       const dataToUse = ds.data.find((item) => item.project_id === this.activeEntry.project_id);
       customerName = dataToUse.customer_name;
       projectName = dataToUse.project_name;
-
     });
     return this.requiredFieldsForInternalAppExist(customerName, projectName) && this.entryForm.valid;
   }
@@ -209,10 +205,14 @@ export class EntryFieldsComponent implements OnInit, OnDestroy {
 
   requiredFieldsForInternalAppExist(customerName, projectName) {
     const emptyValue = '';
-    const areEmptyValues = [this.entryForm.value.uri, this.entryForm.value.description].every(item => item === emptyValue);
-
-    const isInternalApp = customerName.includes('ioet');
-    const canSkipDescriptionAndURI = PROJECT_NAME_TO_SKIP.some(projectNameItem => projectName.includes(projectNameItem));
+    const areEmptyValues = [this.entryForm.value.uri, this.entryForm.value.description].every(
+      (item) => item === emptyValue
+    );
+
+    const isInternalApp = customerName.includes(INTERNAL_APP_STRING);
+    const canSkipDescriptionAndURI = PROJECT_NAME_TO_SKIP.some((projectNameItem) =>
+      projectName.includes(projectNameItem)
+    );
 
     if (isInternalApp && areEmptyValues && !canSkipDescriptionAndURI) {
       this.toastrService.error(EMPTY_FIELDS_ERROR_MESSAGE);