refactor: TTL-886 improve logic for required fields for internal apps

Author: Santiago220991

src/app/modules/time-entries/pages/time-entries.component.ts

@@ -153,26 +153,12 @@ export class TimeEntriesComponent implements OnInit, OnDestroy, AfterViewInit {
         this.toastrService.error(`You are on the clock and this entry overlaps it, ${message}.`);
         this.isActiveEntryOverlapping = false;
       } else {
-        if (this.entry.project_name.includes('(Applications)')) {
-          if (event.entry.uri === '' && event.entry.description === '') {
-            const message = 'The description field or ticket field should not be empty';
-            this.toastrService.error(`Some fields are empty, ${message}.`);
-          } else {
-            this.doSave(event);
-          }
-        } else {
+        if (this.requiredFieldsForInternalAppExist(event)) {
           this.doSave(event);
         }
       }
     } else {
-      if (this.entry.project_name.includes('(Applications)')) {
-        if (event.entry.uri === '' && event.entry.description === '') {
-          const message = 'The description field or ticket field should not be empty';
-          this.toastrService.error(`Some fields are empty, ${message}.`);
-        } else {
-          this.doSave(event);
-        }
-      } else {
+      if (this.requiredFieldsForInternalAppExist(event)) {
         this.doSave(event);
       }
     }
@@ -275,4 +261,16 @@ export class TimeEntriesComponent implements OnInit, OnDestroy, AfterViewInit {
       });
     }
   }
+
+  // Check required fields for internal apps (Ticket number or Description field should exist).
+  requiredFieldsForInternalAppExist(event) {
+    const emptyFields = event.entry.uri === '' && event.entry.description === '';
+    const isInternalApp = this.entry.project_name.includes('(Applications)');
+    if (isInternalApp && emptyFields) {
+      const message = 'The description field or ticket field should not be empty';
+      this.toastrService.error(`Some fields are empty, ${message}.`);
+      return false;
+    }
+    return true;
+  }
 }