fix: #89 fixed comments related to remove key id

Author: daros10

src/app/modules/customer-management/components/customer-info/components/create-customer/create-customer.ts

@@ -54,11 +54,10 @@ export class CreateCustomerComponent implements OnInit, OnDestroy {
   }
 
   onSubmit(customerData) {
-    const key = 'id';
     if (this.customerToEdit) {
       const customer = {
         ...customerData,
-        id: this.customerToEdit[key],
+        id: this.customerToEdit.id,
       };
       this.store.dispatch(new UpdateCustomer(customer));
       this.customerForm.reset();

src/app/modules/customer-management/store/customer-management.reducers.ts

@@ -15,12 +15,8 @@ export const initialState: CustomerState = {
   customerIdToEdit: '',
 };
 
-export function customerManagementReducer(
-  state: CustomerState = initialState,
-  action: CustomerManagementActions
-): CustomerState {
+export const customerManagementReducer = (state: CustomerState = initialState, action: CustomerManagementActions) => {
   const customersList = [...state.data];
-  const key = 'id';
   switch (action.type) {
     case CustomerManagementActionTypes.LOAD_CUSTOMERS: {
       return {
@@ -76,7 +72,7 @@ export function customerManagementReducer(
     }
 
     case CustomerManagementActionTypes.DELETE_CUSTOMER_SUCCESS: {
-      const customers = state.data.filter((customer) => customer[key] !== action.customerId);
+      const customers = state.data.filter((customer) => customer.id !== action.customerId);
       return {
         ...state,
         data: customers,
@@ -102,7 +98,7 @@ export function customerManagementReducer(
     }
 
     case CustomerManagementActionTypes.UPDATE_CUSTOMER_SUCCESS: {
-      const index = customersList.findIndex((customer) => customer[key] === action.payload[key]);
+      const index = customersList.findIndex((customer) => customer.id === action.payload.id);
       customersList[index] = action.payload;
       return {
         ...state,
@@ -133,4 +129,4 @@ export function customerManagementReducer(
     default:
       return state;
   }
-}
+};

src/app/modules/customer-management/store/customer-management.selectors.ts

@@ -18,8 +18,7 @@ export const customerIdtoEdit = createSelector(getCustomerState, (state: Custome
 });
 
 export const getCustomerById = createSelector(allCustomers, customerIdtoEdit, (customers, customerId) => {
-  const key = 'id';
   return customers.find((customer) => {
-    return customer[key] === customerId;
+    return customer.id === customerId;
   });
 });

src/app/modules/shared/models/customer.model.ts

@@ -1,4 +1,5 @@
 export interface Customer {
+  id?: string;
   name: string;
   description?: string;
   tenant_id: string;