refactor: TTA-115 changed test descriptions - lint

Author: mmaquina

src/app/modules/internet-connection-status/internet-connection-directives/connection.directive.ts

@@ -15,17 +15,15 @@ export class ConnectionDirective implements OnInit {
 
     ngOnInit() {
         const { effectiveType } = navigator.connection;
-        let networkSatus;
+        let networkStatus;
         if (/\fast-5g|3g|4g/.test(effectiveType)) {
-            networkSatus = this.fastSrc;
-            return;
+            networkStatus = this.fastSrc;
+        } else if (/\slow-2g|2g/.test(effectiveType))  {
+            networkStatus = this.slowSrc;
+        } else {
+            networkStatus = this.offlineSrc;
         }
-        if (/\slow-2g|2g/.test(effectiveType))  {
-            networkSatus = this.slowSrc;
-            return;
-        }
-        networkSatus = this.offlineSrc;
 
-        this.host.nativeElement.setAttribute('src', networkSatus);
+        this.host.nativeElement.setAttribute('src', networkStatus);
     }
 }

src/app/modules/internet-connection-status/internet-connection-status.component.spec.ts

@@ -32,21 +32,21 @@ describe('InternetConnectionStatusComponent', () => {
     fixture.detectChanges();
   });
 
-  it('should show a stable connection warning', () => {
+  it('component.isFast should be true when the connection is 4g', () => {
     component.connection$ = of('4g');
     fixture.detectChanges();
     component.ngOnInit();
     expect(component.isFast).toBe(true);
   });
 
-  it('should show a slow connection warning', () => {
+  it('component.isFast should be false when the connection is 2g', () => {
     component.connection$ = of('2g');
     fixture.detectChanges();
     component.ngOnInit();
     expect(component.isFast).toBe(false);
   });
 
-  it('should show offline warning', () => {
+  it('component.isFast should be false when the connection is Offline', () => {
     component.connection$ = of('Offline');
     fixture.detectChanges();
     component.ngOnInit();

src/app/modules/internet-connection-status/internet-connection-status.component.ts

@@ -69,15 +69,15 @@ export class InternetConnectionStatusComponent implements OnInit {
         this.connectionType = effectiveType;
 
         if (/\fast-5g|3g|4g/.test(effectiveType)) {
-          this.toastrService.error('Your request was not completed, you are offline');
           this.isFast = true;
           return;
         }
         if (/\slow-2g|2g/.test(effectiveType)) {
-            this.toastrService.warning('Caution your connection is slow');
-            this.isFast = false;
-            return;
+          this.toastrService.warning('Caution your connection is slow');
+          this.isFast = false;
+          return;
         }
+        this.toastrService.warning('Caution your connection is slow');
         this.isFast = false;
       });
   }

src/app/modules/time-clock/store/entry.effects.ts

@@ -37,7 +37,8 @@ export class EntryEffects {
           return new actions.ClockIn(entry);
         }),
         catchError((error) => {
-          this.statusNetworkService.showTypeToastrServiceAlert({error, message: 'We could not perform this operation, try again later', isError: false});
+          this.statusNetworkService.showTypeToastrServiceAlert(
+            {error, message: 'We could not perform this operation, try again later', isError: false});
           return of(new actions.StopTimeEntryRunningFail(error));
         })
       )
@@ -56,7 +57,8 @@ export class EntryEffects {
           return new actions.LoadEntriesSummarySuccess(response);
         }),
         catchError((error) => {
-          this.statusNetworkService.showTypeToastrServiceAlert({error, message: 'Your summary information could not be loaded', isError: false});
+          this.statusNetworkService.showTypeToastrServiceAlert(
+            {error, message: 'Your summary information could not be loaded', isError: false});
           return of(new actions.LoadEntriesSummaryFail());
         })
       )
@@ -151,7 +153,8 @@ export class EntryEffects {
           if (error.status === 404) {
             return of(new actions.CreateEntry(entry));
           } else {
-            this.statusNetworkService.showTypeToastrServiceAlert({error, message: 'We could not clock you in, try again later.', isError: true});
+            this.statusNetworkService.showTypeToastrServiceAlert(
+              {error, message: 'We could not clock you in, try again later.', isError: true});
             return of(new actions.CreateEntryFail('Error'));
           }
         })