code-smell: TT-317 remove code smells indicated by sonarcloud

Author: bytesantiago

src/app/modules/shared/feature-toggles/feature-toggle-general/feature-toggle-general.service.spec.ts

@@ -1,4 +1,3 @@
-import { FeatureToggle } from './../../../../../environments/enum';
 import { TestBed } from '@angular/core/testing';
 import { of } from 'rxjs';
 import { FeatureManagerService } from '../feature-toggle-manager.service';

src/app/modules/shared/feature-toggles/feature-toggle-general/feature-toggle-general.service.ts

@@ -1,5 +1,3 @@
-import { map } from 'rxjs/operators';
-import { FeatureToggle } from './../../../../../environments/enum';
 import { Injectable } from '@angular/core';
 import { Observable } from 'rxjs';
 import { FeatureManagerService } from '../feature-toggle-manager.service';

src/app/modules/shared/feature-toggles/feature-toggle-manager.service.spec.ts

@@ -9,8 +9,6 @@ import { TargetingFeatureFilterModel } from './filters/targeting/targeting-featu
 
 
 describe('FeatureToggleManager', () => {
-  const featureToggleKey = 'foo';
-  const featureToggleLabel = 'dev';
   const fakeAppConfigurationConnectionString = 'Endpoint=http://fake.foo;Id=fake.id;Secret=fake.secret';
   const aFeatureToggle = new FeatureToggleModel('any-id', true, []);
   let service: FeatureManagerService;
@@ -40,15 +38,13 @@ describe('FeatureToggleManager', () => {
     );
 
     let aToggleWithFilters;
-    let getFeatureToggleSpy;
 
     beforeEach(() => {
       aToggleWithFilters = new FeatureToggleModel('any-other-id', true, [anyMatchingFilter]);
       fakeFeatureToggleProvider = new FeatureToggleProvider(
         new AppConfigurationClient(fakeAppConfigurationConnectionString),
         new FeatureFilterProvider(new AzureAdB2CService())
       );
-      getFeatureToggleSpy = spyOn(fakeFeatureToggleProvider, 'getFeatureToggle').and.returnValue(of(aToggleWithFilters));
       service = new FeatureManagerService(fakeFeatureToggleProvider);
     });
 

src/app/modules/shared/feature-toggles/feature-toggle-manager.service.ts

@@ -1,5 +1,5 @@
 import { Injectable } from '@angular/core';
-import { from, Observable, zip } from 'rxjs';
+import { from, Observable} from 'rxjs';
 import { map } from 'rxjs/operators';
 import { FeatureToggleProvider } from './feature-toggle-provider.service';
 import { FeatureToggleModel } from './feature-toggle.model';