fix: TT-509 pr comments

Author: jatobrun

Dockerfile

@@ -37,6 +37,12 @@ RUN chown -R ${USERNAME}:${USERNAME} /var/cache/nginx && \
     chown -R ${USERNAME}:${USERNAME} /etc/nginx/conf.d
 RUN touch /var/run/nginx.pid && chown -R ${USERNAME}:${USERNAME} /var/run/nginx.pid
 
-#USER ${USERNAME}
+# FIXME: Actually if we can deploy to azure in port 80 we need a root user 
+# Maybe we can refactor this dockerfile to use root user directly this is not a good approach y 
+# security terms. It's a good practice to have rootless in containers so for this 
+# we can to refactor this dockerfile and the terraform module to deploy in other ports because 
+# Ports below 1024 needs root permisions.
+ 
+# USER ${USERNAME}
 
 EXPOSE 80

infrastructure/main.tf

@@ -32,28 +32,20 @@ data "terraform_remote_state" "service" {
   }
 }
 
-data "azurerm_container_registry" "registry" {
-  name                = data.terraform_remote_state.service.outputs.container_registry_name
-  resource_group_name = data.terraform_remote_state.service.outputs.resource_group_name
-}
-
-data "azurerm_resource_group" "root" {
-  name = data.terraform_remote_state.service.outputs.resource_group_name
-}
-
 locals {
   common_name             = "time-tracker-ui"
   environment             = terraform.workspace
   service_name            = "${local.common_name}-${local.environment}"
   create_app_service_plan = true
   service_plan_kind       = "Linux"
+  docker_image_name = "timetracker_ui"
 }
 
 module "ui" {
   source                   = "[email protected]:ioet/infra-terraform-modules.git//azure-app-service?ref=tags/v0.0.5"
   app_service_name         = local.service_name
   create_app_service_plan  = local.create_app_service_plan
-  docker_image_name        = var.docker_image_name
+  docker_image_name        = "${local.docker_image_name}:${var.docker_image_tag}"
   docker_image_namespace   = data.azurerm_container_registry.registry.login_server
   docker_registry_password = data.azurerm_container_registry.registry.admin_password
   docker_registry_url      = data.azurerm_container_registry.registry.login_server