Skip to content

Commit 89f611c

Browse files
author
Edgar Guaman
committed
code-smell: TT-331 Deleting bugs and fixing code smells
1 parent 7f947c9 commit 89f611c

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

src/app/modules/shared/components/sidebar/sidebar.component.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ <h1 class="pl-2 pt-2" style="font-family:spinnaker,sans-serif">ioet</h1>
1414
class="font-poppins relative pl-4 py-3 bg-whiteTW dark:bg-grayTW-dark dark:text-whiteTW"
1515
[ngClass]="{active: item.active}"
1616
>
17-
<i class="{{ item.icon }}"></i>
17+
<em class="{{ item.icon }}"></em>
1818
<h3 class="font-poppins text-base ml-4 pl-3 -mt-6 text-left" >{{ item.text }}</h3>
1919
</a>
2020
<div class="bg-whiteTW pt-2 pr-24 absolute bottom-0 -mb-10 dark:bg-grayTW-dark">
2121
<a class="flex pl-4 mb-4 text-blackTW hover:text-grayTW dark:text-whiteTW" href="#">
22-
<i class="fas fa-sign-out-alt"></i>
22+
<em class="fas fa-sign-out-alt"></em>
2323
<span class="font-poppins pl-3 font-medium -mt-1 dark:text-whiteTW" (click)="logout()">Sign out</span>
2424
</a>
2525
<app-dark-mode class="relative left-40 -top-14"></app-dark-mode>
@@ -29,11 +29,11 @@ <h3 class="font-poppins text-base ml-4 pl-3 -mt-6 text-left" >{{ item.text }}</h
2929
<div class="table-cell relative">
3030
<span class="absolute cursor-pointer inset-y-0 right-0 min-h-screen w-0.5 hover:z-0 hover:bg-primaryTW-light" (click)="toggleSideBar()"></span>
3131
<span class="group cursor-pointer absolute w-5 top-28 -right-3">
32-
<img src="assets/icons/left-chevron.svg" id="hide-sidebar" (click)="toggleSideBar()" width="20" height="20" class="bg-whiteTW rounded-full hover:bg-opacity-50 hover:bg-primaryTW-light sm:hidden md:block lg:block"/>
32+
<img src="assets/icons/left-chevron.svg" alt="left-chevron" id="hide-sidebar" (click)="toggleSideBar()" width="20" height="20" class="bg-whiteTW rounded-full hover:bg-opacity-50 hover:bg-primaryTW-light sm:hidden md:block lg:block"/>
3333
<div class="opacity-0 w-12 bg-blackTW text-whiteTW text-center text-xs rounded-lg py-2 absolute z-10 group-hover:opacity-100 bottom-full left-1/4 ml-4 -mb-6 px-1 pointer-events-none">Hide</div>
3434
</span>
3535
<span class="group cursor-pointer absolute top-20 -right-5">
36-
<img src="assets/icons/right-chevron.svg" id="show-sidebar" (click)="toggleSideBar()" width="20" height="20" class="bg-whiteTW rounded-full hover:bg-opacity-50 hover:bg-primaryTW-light sm:block md:hidden lg:hidden"/>
36+
<img src="assets/icons/right-chevron.svg" alt="right-chevron" id="show-sidebar" (click)="toggleSideBar()" width="20" height="20" class="bg-whiteTW rounded-full hover:bg-opacity-50 hover:bg-primaryTW-light sm:block md:hidden lg:hidden"/>
3737
<div class="opacity-0 w-12 bg-blackTW text-whiteTW text-center text-xs rounded-lg py-2 absolute z-10 group-hover:opacity-100 bottom-full left-1/4 ml-4 -mb-6 px-1 pointer-events-none">Show</div>
3838
</span>
3939
</div>

src/styles.scss

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,11 @@
44
@import '~bootstrap/scss/bootstrap';
55
@import './styles/colors.scss';
66
@import '../node_modules/angular-calendar/css/angular-calendar.css';
7+
78
@import 'tailwindcss/base';
89
@import 'tailwindcss/components';
910
@import 'tailwindcss/utilities';
1011

11-
@import "tailwindcss/base";
12-
@import "tailwindcss/components";
13-
@import "tailwindcss/utilities";
14-
1512
html,
1613
body {
1714
font-family: 'Roboto', sans-serif;

0 commit comments

Comments
 (0)