refactor: TT-304 Handle message: Editing methods and unit tests associated

Author: Edgar Guaman

src/app/modules/time-entries/pages/time-entries.component.html

@@ -54,12 +54,12 @@
             <th class="col"></th>
           </tr>
         </thead>
-        <tr *ngIf="checkIfDataSourceIsLoading(dataSource)">
+        <tr *ngIf="checkIfDataSourceIsLoadingorEmpty(dataSource)">
           <td class="text-center" colspan="7">{{NO_DATA_MESSAGE}}</td>
         </tr>
         <app-loading-bar *ngIf="dataSource.isLoading"></app-loading-bar>
         <tbody *ngIf="!dataSource.isLoading">
-          <tr *ngIf="checkIfDataSourceIsEmpty(dataSource)">
+          <tr *ngIf="checkIfDataSourceIsLoadingorEmpty(dataSource)">
             <td class="text-center" colspan="7">{{NO_DATA_MESSAGE}}</td>
           </tr>
           <tr class="d-flex" *ngFor="let entry of dataSource.data">

src/app/modules/time-entries/pages/time-entries.component.spec.ts

@@ -670,22 +670,22 @@ describe('TimeEntriesComponent', () => {
   });
 
   it('checkIfDataSourceIsLoading should be false when dataSource.isLoading is false', () => {
-    expect(component.checkIfDataSourceIsLoading(state.timeEntriesDataSource)).toBeFalse();
+    expect(component.checkIfDataSourceIsLoadingorEmpty(state.timeEntriesDataSource)).toBeFalse();
   });
 
   it('checkIfDataSourceIsLoading should be true when dataSource.isLoading is true', () => {
     state.timeEntriesDataSource.isLoading = true;
 
-    expect(component.checkIfDataSourceIsLoading(state.timeEntriesDataSource)).toBeTrue();
+    expect(component.checkIfDataSourceIsLoadingorEmpty(state.timeEntriesDataSource)).toBeTrue();
   });
 
   it('checkIfDataSourceIsEmpty should be false when dataSource.data.length is not empty', () => {
-    expect(component.checkIfDataSourceIsEmpty(state.timeEntriesDataSource)).toBeFalse();
+    expect(component.checkIfDataSourceIsLoadingorEmpty(state.timeEntriesDataSource)).toBeFalse();
   });
 
   it('checkIfDataSourceIsEmpty should be true when dataSource.data.length is empty', () => {
     state.timeEntriesDataSource.data = [];
 
-    expect(component.checkIfDataSourceIsEmpty(state.timeEntriesDataSource)).toBeTrue();
+    expect(component.checkIfDataSourceIsLoadingorEmpty(state.timeEntriesDataSource)).toBeTrue();
   });
 });

src/app/modules/time-entries/pages/time-entries.component.ts

@@ -219,15 +219,8 @@ export class TimeEntriesComponent implements OnInit, OnDestroy {
     }
   }
 
-  checkIfDataSourceIsLoading(data: DataSource<Entry>): boolean {
-    if (data.isLoading) {
-      return true;
-    }
-    return false;
-  }
-
-  checkIfDataSourceIsEmpty(data: DataSource<Entry>): boolean {
-    if (data.data.length === 0) {
+  checkIfDataSourceIsLoadingorEmpty(source?: DataSource<Entry>): boolean {
+    if (source.isLoading || source.data.length === 0) {
       return true;
     }
     return false;