fix: spinner test

Author: Nicole Garcia

src/app/modules/shared/components/spinner-overlay/spinner-overlay.component.html

@@ -2,7 +2,7 @@ import { Component } from '@angular/core';
 
 @Component({
   selector: 'app-spinner-overlay',
-  templateUrl: './spinner-overlay.component.html',
+  template: '<mat-spinner diameter="80"></mat-spinner>',
   styleUrls: ['./spinner-overlay.component.scss'],
 })
 

src/app/modules/shared/components/spinner-overlay/spinner-overlay.component.ts

@@ -17,9 +17,13 @@ export class SpinnerInterceptor implements HttpInterceptor {
     req: HttpRequest<any>,
     next: HttpHandler
   ): Observable<HttpEvent<any>> {
-    const spinnerSubscription: Subscription = this.spinnerOverlayService.spinner$.subscribe();
-    return next
-      .handle(req)
-      .pipe(finalize(() => spinnerSubscription.unsubscribe()));
+    if(req.url.endsWith('recent')) {
+      const spinnerSubscription: Subscription = this.spinnerOverlayService.spinner$.subscribe();
+      return next
+        .handle(req)
+        .pipe(finalize(() => spinnerSubscription.unsubscribe()));
+    }else {
+      return next.handle(req);
+    }
   }
 }

src/app/modules/shared/interceptors/spinner.interceptor.ts

@@ -44,16 +44,23 @@ describe('SpinnerOverlayService test', () => {
   });
 
   it('if request is made then spinnerService is show', () => {
-    const request = new HttpRequest('GET', '/foo');
+    const request = new HttpRequest('GET', '/recent');
     spyOn(spinnerService, 'show');
-    spyOn(spinnerService, 'hide');
 
     spinnerInterceptor.intercept(request, mockHttpHandler);
 
     expect(spinnerService.show).toHaveBeenCalled();
-    expect(overlayRef).toBeUndefined();
     expect(ComponentPortal).toBeTruthy();
+  });
+
+  it('if request get response spinnerService is hide', () => {
+    const request = new HttpRequest('GET', '/recent');
+    spyOn(spinnerService, 'hide');
+
+    spinnerInterceptor.intercept(request, mockHttpHandler);
+
     expect(spinnerService.hide).toBeTruthy();
+    expect(overlayRef).toBeUndefined();
   });
 
 });