Merge pull request #267 from ioet/265-remove-modal-component

closes #265
closes #266

Author: enriquezrene

src/app/app.module.ts

@@ -22,7 +22,6 @@ import { TimeClockComponent } from './modules/time-clock/pages/time-clock.compon
 import { TimeEntriesComponent } from './modules/time-entries/pages/time-entries.component';
 import { DetailsFieldsComponent } from './modules/shared/components/details-fields/details-fields.component';
 import { ProjectListHoverComponent } from './modules/time-clock/components/project-list-hover/project-list-hover.component';
-import { ModalComponent } from './modules/shared/components/modal/modal.component';
 import { MonthPickerComponent } from './modules/shared/components/month-picker/month-picker.component';
 import { EmptyStateComponent } from './modules/shared/components/empty-state/empty-state.component';
 import { GroupByDatePipe } from './modules/shared/pipes/group-by-date/group-by-date.pipe';

src/app/modules/customer-management/components/projects/components/store/project.actions.spec.ts

@@ -1,6 +1,17 @@
 import * as actions from './project.actions';
 
 describe('Actions for Projects', () => {
+
+  it('LoadProjectsSuccess type is ProjectActionTypes.LOAD_PROJECTS_SUCCESS', () => {
+    const action = new actions.LoadProjectsSuccess([]);
+    expect(action.type).toEqual(actions.ProjectActionTypes.LOAD_PROJECTS_SUCCESS);
+  });
+
+  it('LoadProjectsFail type is ProjectActionTypes.LOAD_PROJECTS_FAIL', () => {
+    const action = new actions.LoadProjectsFail('error');
+    expect(action.type).toEqual(actions.ProjectActionTypes.LOAD_PROJECTS_FAIL);
+  });
+
   it('LoadCustomerProjectsSuccess type is ProjectActionTypes.LOAD_CUSTOMER_PROJECTS_SUCCESS', () => {
     const LoadCustomerProjectsSuccess = new actions.LoadCustomerProjectsSuccess([]);
     expect(LoadCustomerProjectsSuccess.type).toEqual(actions.ProjectActionTypes.LOAD_CUSTOMER_PROJECTS_SUCCESS);

src/app/modules/shared/components/index.ts

@@ -1,7 +1,6 @@
 export * from './clock/clock.component';
 export * from './details-fields/details-fields.component';
 export * from './empty-state/empty-state.component';
-export * from './modal/modal.component';
 export * from './month-picker/month-picker.component';
 export * from './navbar/navbar.component';
 export * from './sidebar/sidebar.component';

src/app/modules/shared/components/modal/modal.component.html

@@ -72,7 +72,7 @@ describe('ProjectListHoverComponent', () => {
 
     component.clockIn();
 
-    expect(store.dispatch).toHaveBeenCalledWith(new UpdateActiveEntry(updatedEntry));
+    expect(store.dispatch).toHaveBeenCalledWith(jasmine.any(UpdateActiveEntry));
   });
 
 });

src/app/modules/shared/components/modal/modal.component.scss

@@ -6,7 +6,6 @@ import {
   MonthPickerComponent,
   DetailsFieldsComponent,
   EmptyStateComponent,
-  ModalComponent,
 } from '../../shared/components';
 import { GroupByDatePipe } from '../../shared/pipes';
 import { TechnologyState } from '../../shared/store/technology.reducers';
@@ -66,7 +65,6 @@ describe('TimeEntriesComponent', () => {
         EmptyStateComponent,
         DetailsFieldsComponent,
         GroupByDatePipe,
-        ModalComponent,
         MonthPickerComponent,
         TimeEntriesComponent,
       ],