Skip to content

Commit 6f32023

Browse files
committed
fix: TT-19 Resolved comments
1 parent f907f3f commit 6f32023

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

src/app/modules/login/login.component.spec.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,9 @@ import { waitForAsync, ComponentFixture, TestBed, inject } from '@angular/core/t
22
import { RouterTestingModule } from '@angular/router/testing';
33
import { AzureAdB2CService } from '../../modules/login/services/azure.ad.b2c.service';
44
import { of } from 'rxjs';
5-
65
import { LoginComponent } from './login.component';
76
import { Router } from '@angular/router';
87
import { FeatureToggleCookiesService } from '../shared/feature-toggles/feature-toggle-cookies/feature-toggle-cookies.service';
9-
import { promise } from 'selenium-webdriver';
108

119
describe('LoginComponent', () => {
1210
let component: LoginComponent;
@@ -27,10 +25,10 @@ describe('LoginComponent', () => {
2725

2826
const featureToggleCookiesServiceStub = {
2927
setCookies() {
28+
return null;
3029
}
3130
};
3231

33-
3432
beforeEach(waitForAsync(() => {
3533
TestBed.configureTestingModule({
3634
imports: [ RouterTestingModule ],

src/app/modules/shared/feature-toggles/feature-toggle-general/feature-toggle-general.service.spec.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ describe('FeatureToggleGeneralService', () => {
4848
expect(featureToggleEnableForUser.length).toEqual(1);
4949
expect(featureToggleEnableForUser).toEqual(fakeAllFeatureaToggleWithFilters);
5050
});
51-
5251
});
5352

5453
it('getActivated return empty', () => {
@@ -59,6 +58,5 @@ describe('FeatureToggleGeneralService', () => {
5958
expect(featureToggleEnableForUser.length).toEqual(0);
6059
expect(featureToggleEnableForUser).toEqual(fakeAllFeatureaToggleWithFilters);
6160
});
62-
6361
});
6462
});

src/app/modules/shared/feature-toggles/feature-toggle-provider.service.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ describe('FeatureToggleProvider', () => {
8686
});
8787

8888
it('toggle model is built', async () => {
89-
const getFilterConfigurationSpy = spyOn(fakeFeatureFilterProvider, 'getFilterFromConfiguration').and.returnValue(
89+
spyOn(fakeFeatureFilterProvider, 'getFilterFromConfiguration').and.returnValue(
9090
fakeFeatureFilterModel
9191
);
9292

0 commit comments

Comments
 (0)