Skip to content

Commit 665aa57

Browse files
authored
Merge pull request #491 from ioet/489_send_tz_offset_in_get_time_entries
feat: 💥 send timezone offset in get time-entries #489
2 parents 6cb411b + f7cda1a commit 665aa57

File tree

2 files changed

+20
-3
lines changed

2 files changed

+20
-3
lines changed

src/app/modules/time-clock/services/entry.service.spec.ts

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,10 @@ describe('EntryService', () => {
5555

5656
it('load all Entries', () => {
5757
const month = new Date().getMonth();
58+
const timezoneOffset = new Date().getTimezoneOffset();
5859
service.loadEntries(month).subscribe();
5960

60-
const loadEntryRequest = httpMock.expectOne(`${service.baseUrl}?month=${month}`);
61+
const loadEntryRequest = httpMock.expectOne(`${service.baseUrl}?month=${month}&timezone_offset=${timezoneOffset}`);
6162
expect(loadEntryRequest.request.method).toBe('GET');
6263

6364
});
@@ -115,6 +116,20 @@ describe('EntryService', () => {
115116
expect(loadEntryRequest.request.params.get('limit')).toEqual('9999');
116117
});
117118

119+
it('when getting time entries for report, timezone_offset parameter should be sent', () => {
120+
const yesterday = moment(new Date()).subtract(1, 'day');
121+
const today = moment(new Date());
122+
const timeRange: TimeEntriesTimeRange = { start_date: yesterday, end_date: today };
123+
const userId = '123';
124+
125+
service.loadEntriesByTimeRange(timeRange, userId).subscribe();
126+
127+
const loadEntryRequest = httpMock.expectOne(req => req.method === 'GET' && req.url === service.baseUrl);
128+
129+
const timezoneOffset = new Date().getTimezoneOffset().toString();
130+
expect(loadEntryRequest.request.params.get('timezone_offset')).toEqual(timezoneOffset);
131+
});
132+
118133
it('when restarting entry, a POST is triggered', () => {
119134
const entry = 'entryId';
120135

src/app/modules/time-clock/services/entry.service.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ export class EntryService {
2424
}
2525

2626
loadEntries(month): Observable<any> {
27-
return this.http.get(`${this.baseUrl}?month=${month}`);
27+
const timezoneOffset = new Date().getTimezoneOffset();
28+
return this.http.get(`${this.baseUrl}?month=${month}&timezone_offset=${timezoneOffset}`);
2829
}
2930

3031
createEntry(entryData): Observable<any> {
@@ -70,7 +71,8 @@ export class EntryService {
7071
start_date: this.datePipe.transform(range.start_date, EntryService.TIME_ENTRIES_DATE_TIME_FORMAT),
7172
end_date: this.datePipe.transform(range.end_date, EntryService.TIME_ENTRIES_DATE_TIME_FORMAT),
7273
user_id: userId,
73-
limit: `${MAX_NUMBER_OF_ENTRIES_FOR_REPORTS}`
74+
limit: `${MAX_NUMBER_OF_ENTRIES_FOR_REPORTS}`,
75+
timezone_offset : new Date().getTimezoneOffset().toString(),
7476
}
7577
}
7678
);

0 commit comments

Comments
 (0)