Skip to content

Commit 63d3cc1

Browse files
committed
fix: #284 adding unit tests
1 parent a991d68 commit 63d3cc1

File tree

2 files changed

+23
-1
lines changed

2 files changed

+23
-1
lines changed

src/app/modules/time-clock/pipes/time-details.pipe.spec.ts

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { TimeDetails } from './../models/time.entry.summary';
12
import { TimeDetailsPipe } from './time-details.pipe';
23

34
describe('TimeDetailsPipe', () => {
@@ -10,4 +11,21 @@ describe('TimeDetailsPipe', () => {
1011
const pipe = new TimeDetailsPipe();
1112
expect(pipe.formatAsTwoDigit('5')).toBe('05');
1213
});
14+
15+
it('returns the same data if number has 2 digits', () => {
16+
const pipe = new TimeDetailsPipe();
17+
expect(pipe.formatAsTwoDigit('15')).toBe('15');
18+
});
19+
20+
it('formats hour in expected format', () => {
21+
const timeDetails = { hours: '1', minutes: '9', seconds: '00'};
22+
const pipe = new TimeDetailsPipe();
23+
expect('01:09').toBe(pipe.transform(timeDetails));
24+
});
25+
26+
it('returns --:-- when timeDetails is null', () => {
27+
const timeDetails = null;
28+
const pipe = new TimeDetailsPipe();
29+
expect('--:--').toBe(pipe.transform(timeDetails));
30+
});
1331
});

src/app/modules/time-clock/pipes/time-details.pipe.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,11 @@ import { Pipe, PipeTransform } from '@angular/core';
77
export class TimeDetailsPipe implements PipeTransform {
88

99
transform(value: TimeDetails): string {
10-
return `${this.formatAsTwoDigit(value?.hours)}:${this.formatAsTwoDigit(value?.minutes)}` ;
10+
if (value) {
11+
return `${this.formatAsTwoDigit(value.hours)}:${this.formatAsTwoDigit(value.minutes)}`;
12+
} else {
13+
return '--:--';
14+
}
1115
}
1216

1317
formatAsTwoDigit(time: string): string {

0 commit comments

Comments
 (0)