Skip to content

Commit 610385a

Browse files
committed
Adjust to split the docker image base of dev and test
1 parent 6dd7be5 commit 610385a

File tree

2 files changed

+13
-10
lines changed

2 files changed

+13
-10
lines changed

Makefile

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,17 @@ help: ## Show this help message.
99
@grep --no-filename -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | \
1010
sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}'
1111

12-
.PHONY: build_dev
13-
build_dev: ## Create docker image with dependencies needed for development.
14-
docker-compose build timetracker_ui_dev
12+
.PHONY: build
13+
build: ## Create docker image with dependencies needed for development.
14+
docker-compose build timetracker_ui
1515

1616
.PHONY: cleanup
1717
cleanup: ## Delete image timetracker_ui
1818
docker rmi timetracker_ui
1919

2020
.PHONY: run
2121
run: ## Execute timetracker_ui dev docker containe.
22-
docker-compose up -d timetracker_ui_dev
22+
docker-compose up -d timetracker_ui
2323

2424
.PHONY: logs
2525
logs: ## Show logs of timetracker_ui.
@@ -40,7 +40,8 @@ remove: ## Delete container timetracker_ui.
4040

4141
.PHONY: test
4242
test: ## Run all tests on docker container timetracker_ui at the CLI.
43-
docker-compose -f docker-compose.yml up -d
43+
docker-compose build timetracker_ui
44+
docker-compose up -d timetracker_ui
4445
docker exec timetracker_ui bash -c "npm run ci-test"
4546

4647
.PHONY: testdev

docker-compose.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
version: '3.9'
22
services:
3-
timetracker_ui_dev:
4-
container_name: timetracker_ui_dev
5-
image: timetracker_ui_dev
3+
timetracker_ui:
4+
container_name: timetracker_ui
5+
image: timetracker_ui
66
build:
77
context: .
88
dockerfile: ./Docker/dev.Dockerfile
@@ -46,11 +46,13 @@ services:
4646

4747
timetracker_ui_test:
4848
container_name: timetracker_ui_test
49-
image: timetracker_ui_test
49+
image: timetracker_ui
5050
build:
5151
# target: production
5252
context: .
53-
dockerfile: ./Docker/test.Dockerfile
53+
dockerfile:
54+
./Docker/dev.Dockerfile
55+
./Docker/test.Dockerfile
5456
ports:
5557
- 4200:4200
5658
- 9876:9876

0 commit comments

Comments
 (0)