code-smell: TT-337 Fixing code smells

Author: Edgar Guaman

src/app/modules/activities-management/components/activity-list/activity-list.component.ts

@@ -69,7 +69,8 @@ export class ActivityListComponent implements OnInit {
 
   updateActivity(activityId: string): void {
     this.store.dispatch(new SetActivityToEdit(activityId));
-    this.changeValueShowActivityForm.emit(this.showActivityForm = true);
+    this.showActivityForm = true;
+    this.changeValueShowActivityForm.emit(this.showActivityForm);
   }
 
   unarchiveActivity(): void {

src/app/modules/activities-management/components/create-activity/create-activity.component.html

@@ -1,7 +1,4 @@
-<h4>Activities</h4>
-<hr/>
 <div>
-
   <form [formGroup]="activityForm" (ngSubmit)="onSubmit(activityForm.value)">
     <div class="form-group">
       <label>Name:</label>

src/app/modules/activities-management/components/create-activity/create-activity.component.ts

@@ -1,5 +1,5 @@
 import { FormBuilder, Validators, FormGroup } from '@angular/forms';
-import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core';
+import { Component, EventEmitter, OnInit, Output } from '@angular/core';
 import { Store, select } from '@ngrx/store';
 import { Activity } from '../../../shared/models';
 import { ActivityState } from './../../store/activity-management.reducers';

src/app/modules/activities-management/pages/activities-management.component.ts

@@ -18,7 +18,7 @@ export class ActivitiesManagementComponent {
 
   activateActivityForm() {
     this.store.dispatch(new SetActivityToEdit(null));
-    this.showActivityForm === false ? this.showActivityForm = true : this.showActivityForm = false;
+    !this.showActivityForm ? this.showActivityForm = true : this.showActivityForm = false;
   }
 
   closeFormActivity(event) {