test: TTL-910 fix tests

Author: Santiago220991

src/app/modules/reports/components/time-range-custom/time-range-custom.component.spec.ts

@@ -131,15 +131,15 @@ describe('TimeRangeCustomComponent', () => {
   });
 
   it('When the ngOnChanges method is the first change, the onSubmit method is not called', () => {
-    const userIdNotCalled = 'user-2';
-    const projectIdNotCalled = 'project_id';
-    const activityIdNotCalled = 'activity_id';
+    const userId = 'user-2';
+    const projectId = 'project_id';
+    const activityId = 'activity_id';
     spyOn(component, 'onSubmit');
 
     component.ngOnChanges({
-      userId: new SimpleChange(null, userIdNotCalled, true),
-      projectId: new SimpleChange(null, projectIdNotCalled, true),
-      activityId: new SimpleChange(null, activityIdNotCalled, true),
+      userId: new SimpleChange(null, userId, true),
+      projectId: new SimpleChange(null, projectId, true),
+      activityId: new SimpleChange(null, activityId, true),
     });
 
     expect(component.onSubmit).not.toHaveBeenCalled();

src/app/modules/reports/components/time-range-form/time-range.component.spec.ts

@@ -147,15 +147,15 @@ describe('Reports Page', () => {
     });
 
     it('When the ngOnChanges method is the first change, the onSubmit method is not called', () => {
-      const userIdNotCalled = 'user_id';
-      const projectIdNotCalled = 'project_id';
-      const activityIdNotCalled = 'activity_id';
+      const userId = 'user_id';
+      const projectId = 'project_id';
+      const activityId = 'activity_id';
       spyOn(component, 'onSubmit');
 
       component.ngOnChanges({
-        userId: new SimpleChange(null, userIdNotCalled, true),
-        projectId: new SimpleChange(null, projectIdNotCalled, true),
-        activityId: new SimpleChange(null, activityIdNotCalled, true),
+        userId: new SimpleChange(null, userId, true),
+        projectId: new SimpleChange(null, projectId, true),
+        activityId: new SimpleChange(null, activityId, true),
       });
 
       expect(component.onSubmit).not.toHaveBeenCalled();