Skip to content

Commit 4a8aa30

Browse files
committed
fix: TT-513 Merge with master
2 parents 43042db + 75e909a commit 4a8aa30

29 files changed

+616
-189
lines changed

Makefile

Lines changed: 35 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ testdev: ## Run all tests on docker container timetracker_ui at the Dev
4949
docker exec timetracker_ui bash -c "npm run ci-test"
5050

5151
.PHONY: publish
52-
publish: require-acr-arg require-image_tag-arg ## Upload a docker image to an azure container registry acr=<name_of_the_azure_container_registry> image_tag=<tag_for_the_image>
53-
docker tag timetracker_api $(acr).azurecr.io/timetracker_api:$(image_tag)
54-
docker push $(acr).azurecr.io/timetracker_api:$(image_tag)
52+
publish: require-acr-arg require-image_tag-arg ## Upload a docker image to the stage azure container registry acr=<name_of_the_azure_container_registry> image_tag=<tag_for_the_image>
53+
docker tag timetracker_ui:latest $(acr).azurecr.io/timetracker_ui:$(image_tag)
54+
docker push $(acr).azurecr.io/timetracker_ui:$(image_tag)
5555

5656
.PHONY: build_prod
5757
build_prod: ## Create docker image with dependencies needed for production.
@@ -61,16 +61,47 @@ build_prod: ## Create docker image with dependencies needed for production.
6161
run_prod: ## Execute timetracker_ui_prod docker container.
6262
docker run -d -p 4200:4200 --name timetracker_ui_prod timetracker_ui_prod
6363

64+
.PHONY: stop_prod
65+
stop_prod: ## Stop container timetracker_ui_prod.
66+
docker stop timetracker_ui_prod
67+
6468
.PHONY: remove_prod
65-
remove_prod: ## Delete container timetracker_ui_pro.
69+
remove_prod: ## Delete container timetracker_ui_prod.
6670
docker stop timetracker_ui_prod
6771
docker rm timetracker_ui_prod
6872

6973
.PHONY: publish_prod
74+
<<<<<<< HEAD
7075
publish_prod: ## Publish the container image timetracker_ui_prod.
7176
docker tag timetracker_ui_prod:$(image_tag) $(registry_url)/timetracker_ui_prod:$(image_tag)
7277
docker push $(registry_url)/timetracker_ui_prod:$(image_tag)
7378

7479
.PHONY: login
7580
login: ## Login in respository of docker images.
7681
az acr login --name $(acr)
82+
=======
83+
publish_prod: require-acr-arg require-image_tag-arg ## Upload a docker image to the prod azure container registry acr=<name_of_the_azure_container_registry> image_tag=<tag_for_the_image>
84+
docker tag timetracker_ui_prod:latest $(acr).azurecr.io/timetracker_ui:$(image_tag)
85+
docker push $(acr).azurecr.io/timetracker_ui:$(image_tag)
86+
87+
.PHONY: login
88+
login: ## Login in respository of docker images.
89+
az acr login --name $(container_registry)
90+
91+
.PHONY: release
92+
release: require-VERSION-arg require-COMMENT-arg ## Creates an pushes a new tag.
93+
git tag -a ${VERSION} -m "${COMMENT}"
94+
git push origin ${VERSION}
95+
96+
require-%-arg:
97+
@if [ -z ${${*}} ]; then \
98+
echo "ERROR: [$*] argument is required, e.g. $*=<value>"; \
99+
exit 1; \
100+
fi
101+
102+
require-%-tool:
103+
@if [ "$(shell command -v ${*} 2> /dev/null)" = "" ]; then \
104+
echo "ERROR: [$*] not found"; \
105+
exit 1; \
106+
fi
107+
>>>>>>> master

infrastructure/main.tf

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -32,34 +32,26 @@ data "terraform_remote_state" "service" {
3232
}
3333
}
3434

35-
data "azurerm_container_registry" "registry" {
36-
name = data.terraform_remote_state.service.outputs.container_registry_name
37-
resource_group_name = data.terraform_remote_state.service.outputs.resource_group_name
38-
}
39-
40-
data "azurerm_resource_group" "root" {
41-
name = data.terraform_remote_state.service.outputs.resource_group_name
42-
}
43-
4435
locals {
4536
common_name = "time-tracker-ui"
4637
environment = terraform.workspace
4738
service_name = "${local.common_name}-${local.environment}"
4839
create_app_service_plan = true
4940
service_plan_kind = "Linux"
41+
image_name = "timetracker_ui"
5042
}
5143

5244
module "ui" {
5345
source = "[email protected]:ioet/infra-terraform-modules.git//azure-app-service?ref=tags/v0.0.5"
5446
app_service_name = local.service_name
5547
create_app_service_plan = local.create_app_service_plan
56-
docker_image_name = var.docker_image_name
57-
docker_image_namespace = data.azurerm_container_registry.registry.login_server
58-
docker_registry_password = data.azurerm_container_registry.registry.admin_password
59-
docker_registry_url = data.azurerm_container_registry.registry.login_server
60-
docker_registry_username = data.azurerm_container_registry.registry.admin_username
61-
location = data.azurerm_resource_group.root.location
62-
resource_group_name = data.azurerm_resource_group.root.name
48+
docker_image_name = "${local.image_name}:${var.image_tag}"
49+
docker_image_namespace = data.terraform_remote_state.service.outputs.container_registry_login_server
50+
docker_registry_password = data.terraform_remote_state.service.outputs.container_registry_admin_password
51+
docker_registry_url = data.terraform_remote_state.service.outputs.container_registry_login_server
52+
docker_registry_username = data.terraform_remote_state.service.outputs.container_registry_admin_username
53+
location = data.terraform_remote_state.service.outputs.container_registry_location
54+
resource_group_name = data.terraform_remote_state.service.outputs.resource_group_name
6355
service_plan_kind = local.service_plan_kind
6456
service_plan_name = local.service_name
6557
service_plan_size = var.service_plan_size

infrastructure/variables.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
variable "docker_image_name" {
1+
variable "image_tag" {
22
type = string
3-
description = "Specifies the docker image name that is stored in a private container registry like ACR (Azure Container Registry)."
3+
description = "Specifies the docker image tag that is stored in a private container registry like ACR (Azure Container Registry)."
44
sensitive = true
55
}
66

0 commit comments

Comments
 (0)