style: #201 Removing unnecessary code and fixing typos

Author: Juan Gabriel Guzman

package.json

@@ -75,7 +75,7 @@
   },
   "config": {
     "commit-message-validator": {
-      "pattern": "^(fix: #|feat: #|perf: #)[0-9].*",
+      "pattern": "^(fix: #|feat: #|perf: #|style: #)[0-9].*",
       "errorMessage": "Your commit message needs to start with fix:, feat:, or perf: followed by issue number, e.g. fix: #43 any commit message"
     }
   },

src/app/modules/time-clock/pages/time-clock.component.spec.ts

@@ -6,7 +6,6 @@ import { provideMockStore, MockStore } from '@ngrx/store/testing';
 import { TimeClockComponent } from './time-clock.component';
 import { ProjectState } from '../../customer-management/components/projects/components/store/project.reducer';
 import { ProjectListHoverComponent } from '../components';
-import { ProjectService } from '../../customer-management/components/projects/components/services/project.service';
 import { FilterProjectPipe } from '../../shared/pipes';
 import { AzureAdB2CService } from '../../login/services/azure.ad.b2c.service';
 import {ActionsSubject} from '@ngrx/store';
@@ -15,7 +14,6 @@ describe('TimeClockComponent', () => {
   let component: TimeClockComponent;
   let fixture: ComponentFixture<TimeClockComponent>;
   let store: MockStore<ProjectState>;
-  let projectService: ProjectService;
   let azureAdB2CService: AzureAdB2CService;
   const actionSub: ActionsSubject = new ActionsSubject();
   const state = {
@@ -46,7 +44,7 @@ describe('TimeClockComponent', () => {
     TestBed.configureTestingModule({
       imports: [HttpClientTestingModule],
       declarations: [TimeClockComponent, ProjectListHoverComponent, FilterProjectPipe],
-      providers: [ProjectService,
+      providers: [
         AzureAdB2CService,
         { provide: ActionsSubject, useValue: actionSub },
         provideMockStore({ initialState: state })],
@@ -58,7 +56,6 @@ describe('TimeClockComponent', () => {
     fixture = TestBed.createComponent(TimeClockComponent);
     component = fixture.componentInstance;
     fixture.detectChanges();
-    projectService = TestBed.inject(ProjectService);
     azureAdB2CService = TestBed.inject(AzureAdB2CService);
   });
 
@@ -82,13 +79,6 @@ describe('TimeClockComponent', () => {
     expect(azureAdB2CService.getName).toHaveBeenCalledTimes(0);
   });
 
-  it('Service injected via inject(...) and TestBed.get(...) should be the same instance', inject(
-    [ProjectService],
-    (injectService: ProjectService) => {
-      expect(injectService).toBe(projectService);
-    }
-  ));
-
   it('clockOut dispatch a StopTimeEntryRunning action', () => {
     spyOn(store, 'dispatch');
 

src/app/modules/time-clock/store/entry.actions.spec.ts

@@ -29,11 +29,11 @@ describe('Actions for Entries', () => {
       project_id: '1',
       description: 'It is good for learning',
     });
-    expect(updateActiveEntrySuccess.type).toEqual(actions.EntryActionTypes.UDPATE_ACTIVE_ENTRY_SUCCESS);
+    expect(updateActiveEntrySuccess.type).toEqual(actions.EntryActionTypes.UPDATE_ACTIVE_ENTRY_SUCCESS);
   });
 
   it('UpdateActiveEntryFail type is EntryActionTypes.UDPATE_ACTIVE_ENTRY_FAIL', () => {
     const updateActiveEntryFail = new actions.UpdateActiveEntryFail('error');
-    expect(updateActiveEntryFail.type).toEqual(actions.EntryActionTypes.UDPATE_ACTIVE_ENTRY_FAIL);
+    expect(updateActiveEntryFail.type).toEqual(actions.EntryActionTypes.UPDATE_ACTIVE_ENTRY_FAIL);
   });
 });

src/app/modules/time-clock/store/entry.actions.ts

@@ -8,9 +8,9 @@ export enum EntryActionTypes {
   CREATE_ENTRY = '[Entry] CREATE_ENTRY',
   CREATE_ENTRY_SUCCESS = '[Entry] CREATE_ENTRY_SUCCESS',
   CREATE_ENTRY_FAIL = '[Entry] CREATE_ENTRY_FAIL',
-  UDPATE_ACTIVE_ENTRY = '[Entry] UDPATE_ACTIVE_ENTRY',
-  UDPATE_ACTIVE_ENTRY_SUCCESS = '[Entry] UDPATE_ACTIVE_ENTRY_SUCCESS',
-  UDPATE_ACTIVE_ENTRY_FAIL = '[Entry] UDPATE_ACTIVE_ENTRY_FAIL',
+  UPDATE_ACTIVE_ENTRY = '[Entry] UPDATE_ACTIVE_ENTRY',
+  UPDATE_ACTIVE_ENTRY_SUCCESS = '[Entry] UPDATE_ACTIVE_ENTRY_SUCCESS',
+  UPDATE_ACTIVE_ENTRY_FAIL = '[Entry] UPDATE_ACTIVE_ENTRY_FAIL',
   STOP_TIME_ENTRY_RUNNING = '[Entry] STOP_TIME_ENTRIES_RUNNING',
   STOP_TIME_ENTRY_RUNNING_SUCCESS = '[Entry] STOP_TIME_ENTRIES_RUNNING_SUCCESS',
   STOP_TIME_ENTRY_RUNNING_FAILED = '[Entry] STOP_TIME_ENTRIES_RUNNING_FAILED',
@@ -50,19 +50,19 @@ export class CreateEntryFail implements Action {
 }
 
 export class UpdateActiveEntry implements Action {
-  public readonly type = EntryActionTypes.UDPATE_ACTIVE_ENTRY;
+  public readonly type = EntryActionTypes.UPDATE_ACTIVE_ENTRY;
 
   constructor(public payload: NewEntry) {}
 }
 
 export class UpdateActiveEntrySuccess implements Action {
-  public readonly type = EntryActionTypes.UDPATE_ACTIVE_ENTRY_SUCCESS;
+  public readonly type = EntryActionTypes.UPDATE_ACTIVE_ENTRY_SUCCESS;
 
   constructor(public payload: NewEntry) {}
 }
 
 export class UpdateActiveEntryFail implements Action {
-  public readonly type = EntryActionTypes.UDPATE_ACTIVE_ENTRY_FAIL;
+  public readonly type = EntryActionTypes.UPDATE_ACTIVE_ENTRY_FAIL;
 
   constructor(public error: string) {}
 }

src/app/modules/time-clock/store/entry.effects.ts

@@ -39,7 +39,7 @@ export class EntryEffects {
 
   @Effect()
   updateActiveEntry$: Observable<Action> = this.actions$.pipe(
-    ofType(actions.EntryActionTypes.UDPATE_ACTIVE_ENTRY),
+    ofType(actions.EntryActionTypes.UPDATE_ACTIVE_ENTRY),
     map((action: actions.UpdateActiveEntry) => action.payload),
     mergeMap((project) =>
       this.entryService.updateActiveEntry(project).pipe(

src/app/modules/time-clock/store/entry.reducer.ts

@@ -65,14 +65,14 @@ export const entryReducer = (state: EntryState = initialState, action: EntryActi
       };
     }
 
-    case EntryActionTypes.UDPATE_ACTIVE_ENTRY: {
+    case EntryActionTypes.UPDATE_ACTIVE_ENTRY: {
       return {
         ...state,
         isLoading: true,
       };
     }
 
-    case EntryActionTypes.UDPATE_ACTIVE_ENTRY_SUCCESS: {
+    case EntryActionTypes.UPDATE_ACTIVE_ENTRY_SUCCESS: {
       const activeEntry = { ...state.active, ...action.payload };
 
       return {
@@ -82,7 +82,7 @@ export const entryReducer = (state: EntryState = initialState, action: EntryActi
       };
     }
 
-    case EntryActionTypes.UDPATE_ACTIVE_ENTRY_FAIL: {
+    case EntryActionTypes.UPDATE_ACTIVE_ENTRY_FAIL: {
       return {
         ...state,
         active: null,