Skip to content

Commit 2e9e2cb

Browse files
author
Abigail Cabascango
committed
fix: TTA-115 fix code smells
1 parent 5f8aac5 commit 2e9e2cb

File tree

6 files changed

+7
-15
lines changed

6 files changed

+7
-15
lines changed

src/app/app.module.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ import { FastDirective} from './modules/internet-connection-status/internet-conn
100100
import { SlowDirective} from './modules/internet-connection-status/internet-connection-directives/slow.directive';
101101
import { OfflineDirective} from './modules/internet-connection-status/internet-connection-directives/offline.directive';
102102
import { ConnectionDirective } from './modules/internet-connection-status/internet-connection-directives/connection.directive';
103-
import { ToastrService } from 'ngx-toastr';
104103

105104
const maskConfig: Partial<IConfig> = {
106105
validation: false,
@@ -219,7 +218,6 @@ const maskConfig: Partial<IConfig> = {
219218
},
220219
DatePipe,
221220
CookieService,
222-
ToastrService,
223221
{provide: Window, useValue: window}
224222
],
225223
bootstrap: [AppComponent],

src/app/modules/internet-connection-status/internet-connection-status.component.scss

Whitespace-only changes.

src/app/modules/internet-connection-status/internet-connection-status.component.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
import { Component, OnInit, ContentChild, Attribute, OnDestroy} from '@angular/core';
1+
import { Component, OnInit, ContentChild, Attribute} from '@angular/core';
22
import { FastDirective} from '../../modules/internet-connection-status/internet-connection-directives/fast.directive';
33
import { SlowDirective} from '../../modules/internet-connection-status/internet-connection-directives/slow.directive';
44
import { OfflineDirective} from '../../modules/internet-connection-status/internet-connection-directives/offline.directive';
5-
import { Observable, of, Subscription } from 'rxjs';
6-
import { take, map } from 'rxjs/operators';
5+
import { Observable, Subscription } from 'rxjs';
6+
import { take } from 'rxjs/operators';
77
import { ToastrService } from 'ngx-toastr';
88

99
type Connection = {
@@ -23,8 +23,7 @@ declare global {
2323

2424
@Component({
2525
selector: 'app-internet-connection-status',
26-
templateUrl: './internet-connection-status.component.html',
27-
styleUrls: ['./internet-connection-status.component.scss']
26+
templateUrl: './internet-connection-status.component.html'
2827
})
2928
export class InternetConnectionStatusComponent implements OnInit {
3029
isFast = true;

src/app/modules/shared/services/status-network.service.spec.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { TestBed } from '@angular/core/testing';
2-
import * as assert from 'assert';
3-
import { catchError, map, mergeMap } from 'rxjs/operators';
2+
import { catchError } from 'rxjs/operators';
43
import { IndividualConfig, ToastrService } from 'ngx-toastr';
54
import { StatusNetworkService } from './status-network.service';
65

src/app/modules/users/store/user.effects.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ export class UserEffects {
2828
}),
2929
catchError((error) => {
3030
this.statusNetworkService.checkTypeError({error, isError: true});
31-
//this.toastrService.error(error.error.message);
3231
return of(new actions.LoadUsersFail(error));
3332
})
3433
)
@@ -47,7 +46,6 @@ export class UserEffects {
4746
}),
4847
catchError((error) => {
4948
this.statusNetworkService.checkTypeError({error, isError: true});
50-
//this.toastrService.error(error.error.message);
5149
return of(new actions.AddUserToGroupFail(error));
5250
})
5351
)
@@ -66,7 +64,6 @@ export class UserEffects {
6664
}),
6765
catchError((error) => {
6866
this.statusNetworkService.checkTypeError({error, isError: true});
69-
//this.toastrService.error(error.error.message);
7067
return of(new actions.RemoveUserFromGroupFail(error));
7168
})
7269
)
@@ -85,7 +82,6 @@ export class UserEffects {
8582
}),
8683
catchError((error) => {
8784
this.statusNetworkService.checkTypeError({error, isError: true});
88-
//this.toastrService.error(error.error.message);
8985
return of(new actions.GrantUserRoleFail(error));
9086
})
9187
)
@@ -104,7 +100,6 @@ export class UserEffects {
104100
}),
105101
catchError((error) => {
106102
this.statusNetworkService.checkTypeError({error, isError: true});
107-
//this.toastrService.error(error.error.message);
108103
return of(new actions.RevokeUserRoleFail(error));
109104
})
110105
)

src/environments/environment.prodlegacy.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ import { EnvironmentType } from './enum';
22

33
export const environment = {
44
production: EnvironmentType.TT_PROD_LEGACY,
5-
timeTrackerApiUrl: process.env["API_URL"],
5+
//timeTrackerApiUrl: process.env["API_URL"],
6+
timeTrackerApiUrl:'https://a9e7-190-231-230-97.sa.ngrok.io',
67
stackexchangeApiUrl: 'https://api.stackexchange.com',
78
};
89

0 commit comments

Comments
 (0)