Skip to content

Commit 258be2b

Browse files
committed
feat: TT-35 solve PR comments
1 parent 379aa93 commit 258be2b

File tree

3 files changed

+13
-7
lines changed

3 files changed

+13
-7
lines changed

src/app/modules/time-entries/pages/time-entries.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
</div>
6262
<div class="modal fade" id="editRecordsByDate" tabindex="-1" role="dialog">
6363
<div class="modal-dialog modal-dialog-centered modal-lg" role="document">
64-
<div class="modal-content" cdkDrag (cdkDragEnded)="dragEnded($event)">
64+
<div class="modal-content" cdkDrag (cdkDragEnded)="resetDraggablePosition($event)">
6565
<div class="modal-header">
6666
<h5 class="modal-title">{{ entryId ? 'Edit Entry' : 'New Entry' }}</h5>
6767
</div>

src/app/modules/time-entries/pages/time-entries.component.spec.ts

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -443,10 +443,16 @@ describe('TimeEntriesComponent', () => {
443443
expect(component.entry).toEqual(newEntry);
444444
});
445445

446-
it('When I stop dragging the modal, it should call dragEnded', () => {
447-
const dragEndEvent = new DragEvent('CdkDragEnd');
448-
spyOn(component, 'dragEnded');
449-
component.dragEnded(dragEndEvent);
450-
expect(component.dragEnded).toHaveBeenCalledWith(dragEndEvent);
446+
it('When I stop dragging the modal, it should reset Draggable Position', () => {
447+
const dragEndEventStub = {
448+
source: {
449+
_dragRef: {
450+
reset: () => { }
451+
}
452+
}
453+
};
454+
spyOn(dragEndEventStub.source._dragRef, 'reset');
455+
component.resetDraggablePosition(dragEndEventStub);
456+
expect(dragEndEventStub.source._dragRef.reset).toHaveBeenCalled();
451457
});
452458
});

src/app/modules/time-entries/pages/time-entries.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ export class TimeEntriesComponent implements OnInit, OnDestroy {
165165
this.message = `Are you sure you want to delete ${item.activity_name}?`;
166166
this.showModal = true;
167167
}
168-
dragEnded(event: any): void {
168+
resetDraggablePosition(event: any): void {
169169
event.source._dragRef.reset();
170170
}
171171
}

0 commit comments

Comments
 (0)