fix: TTA-141 Fix broken tests and test coverage in the UI

Author: jimmyjaramillo

src/app/modules/login/login.component.spec.ts

@@ -8,12 +8,15 @@ import { FeatureToggleCookiesService } from '../shared/feature-toggles/feature-t
 import { LoginService } from './services/login.service';
 import { HttpClientTestingModule } from '@angular/common/http/testing';
 import { SocialAuthService } from 'angularx-social-login';
+import { UserService } from '../user/services/user.service';
+
 
 describe('LoginComponent', () => {
   let component: LoginComponent;
   let fixture: ComponentFixture<LoginComponent>;
   let azureAdB2CService: AzureAdB2CService;
   let loginService: LoginService;
+  let userService: UserService;
   let featureToggleCookiesService: FeatureToggleCookiesService;
 
   const azureAdB2CServiceStub = {
@@ -38,6 +41,16 @@ describe('LoginComponent', () => {
     }
   };
 
+  const userTest = {
+    name: 'user',
+  email: '[email protected]',
+  roles: ['admin'],
+  groups: ['admin'],
+  id: 'user_id',
+  tenant_id: 'tenant_test',
+  deleted: 'no',
+  }
+
   const featureToggleCookiesServiceStub = {
     setCookies() {
       return null;
@@ -66,6 +79,7 @@ describe('LoginComponent', () => {
     fixture.detectChanges();
     azureAdB2CService = TestBed.inject(AzureAdB2CService);
     loginService = TestBed.inject(LoginService);
+    userService = TestBed.inject(UserService);
     featureToggleCookiesService = TestBed.inject(FeatureToggleCookiesService);
   });
 
@@ -90,6 +104,7 @@ describe('LoginComponent', () => {
     spyOn(azureAdB2CService, 'setCookies').and.returnValue();
     spyOn(azureAdB2CService, 'signIn').and.returnValue(of(() => {}));
     spyOn(azureAdB2CService, 'getUserId').and.returnValue('userId_123');
+    spyOn(userService, 'loadUser').withArgs('userId_123').and.returnValue(of(userTest));
     spyOn(featureToggleCookiesService, 'setCookies').and.returnValue(featureToggleCookiesService.setCookies());
 
     component.login();
@@ -98,6 +113,7 @@ describe('LoginComponent', () => {
     expect(azureAdB2CService.setCookies).toHaveBeenCalled();
     expect(azureAdB2CService.getUserId).toHaveBeenCalled();
     expect(featureToggleCookiesService.setCookies).toHaveBeenCalled();
+    expect(userService.loadUser).toHaveBeenCalledWith('userId_123');
   }));
 
   it('should sign up or login with google if is not logged-in into the app Locally', inject([Router],  (router: Router) => {

src/app/modules/login/services/login.service.spec.ts

@@ -1,3 +1,4 @@
+import { HttpClient } from '@angular/common/http';
 import { HttpClientTestingModule, HttpTestingController } from '@angular/common/http/testing';
 import { TestBed } from '@angular/core/testing';
 import { JwtHelperService } from '@auth0/angular-jwt';
@@ -14,6 +15,7 @@ describe('LoginService', () => {
   let socialAuthService: SocialAuthService;
   let account;
   const socialAuthServiceStub = jasmine.createSpyObj('SocialAuthService', ['signOut', 'signIn']);
+  const httpClientSpy = jasmine.createSpyObj('HttpClient', ['post', 'get']);
   const cookieStoreStub = {};
   const helper = new JwtHelperService();
   const getAccountInfo = () => {
@@ -26,6 +28,7 @@ describe('LoginService', () => {
       providers: [
         { providers: CookieService, useValue: cookieStoreStub },
         { provide: SocialAuthService, useValue: socialAuthServiceStub },
+        { provide: HttpClient, useValue: httpClientSpy }
       ],
     });
     service = TestBed.inject(LoginService);
@@ -49,6 +52,7 @@ describe('LoginService', () => {
     spyOn(localStorage, 'setItem').and.callFake(mockLocalStorage.setItem);
     spyOn(localStorage, 'clear').and.callFake(mockLocalStorage.clear);
     localStorage.setItem('user', account);
+    localStorage.setItem('user2', '"test_token_123"');
   });
 
   it('should be created', () => {
@@ -90,12 +94,16 @@ describe('LoginService', () => {
   });
 
   it('load a user by sending a token using POST', () => {
+    const token  = 'test_123'
     service.baseUrl = '/users';
+    const mockSuccessDataPost = {
+      SUCCESS: true,
+      data: {}
+    }
+    httpClientSpy.post.and.returnValue(of(mockSuccessDataPost));
     service.getUser('token').subscribe();
-
-    const loadUserRequest = httpMock.expectOne(`${service.baseUrl}/login`);
-    expect(loadUserRequest.request.method).toBe('POST');
-  });
+    expect(httpClientSpy.post).toHaveBeenCalled();
+    });
 
   it('should return true when user is Login', () => {
     spyOn(cookieService, 'check').and.returnValue(true);
@@ -128,4 +136,40 @@ describe('LoginService', () => {
     expect(localStorage.clear).toHaveBeenCalled();
     expect(cookieService.deleteAll).toHaveBeenCalled();
   });
+
+  it('should call cookieService when app is isLegacyProd', () => {
+    service.isLegacyProd = true;
+    service.localStorageKey = 'user2';
+    spyOn(cookieService, 'check').and.returnValue(true);
+    spyOn(service, 'isValidToken').and.returnValue(of(true));
+    service.isLogin().subscribe(isLogin => {
+      expect(cookieService.check).toHaveBeenCalled();
+    });
+  });
+
+  it('should call JSON parse when app is isLegacyProd', () => {
+    spyOn(JSON, 'parse').and.returnValue('test_user_123');
+    service.isLegacyProd = true;
+    service.localStorageKey = 'user2';
+    service.getUserId();
+    service.getName();
+    service.getUserEmail();
+    service.getUserGroup();
+    expect(JSON.parse).toHaveBeenCalled();
+  });
+
+  it('should call setLocalStorage when there is a new_token ', () => {
+    spyOn(cookieService, 'check').and.returnValue(true);
+    spyOn(service, 'setLocalStorage');
+    const token  = 'test123'
+    service.baseUrl = '/users';
+    const mockSuccessDataPost = {
+      SUCCESS: true,
+      new_token: 'test_token'
+    }
+    httpClientSpy.post.and.returnValue(of(mockSuccessDataPost));
+    service.isValidToken(token).subscribe();
+    expect(service.setLocalStorage).toHaveBeenCalled();
+    expect(cookieService.check).toHaveBeenCalled();
+  });
 });

src/app/modules/user/services/user-info.service.spec.ts

@@ -75,4 +75,13 @@ describe('UserInfoService', () => {
       });
   });
 
+  it('should return true if is Admin and isLegacyProduction', () => {
+    const groupsTT = {groups: ['fake-admin', 'fake-admin-tt']};
+    spyOn(mockLoginService, 'getLocalStorage').and.returnValue(JSON.stringify(groupsTT));
+    service.isLegacyProduction = true;
+      service.isMemberOf('fake-admin').subscribe((value) => {
+        expect(value).toEqual(true);
+      });
+  });
+
 });