Skip to content

Commit 1d5656a

Browse files
committed
fix: TT-593 unit test coverage
1 parent 986fd43 commit 1d5656a

File tree

4 files changed

+17
-19
lines changed

4 files changed

+17
-19
lines changed

src/app/modules/reports/components/time-entries-table/time-entries-table.component.spec.ts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { waitForAsync, ComponentFixture, TestBed } from '@angular/core/testing';
22
import { MockStore, provideMockStore } from '@ngrx/store/testing';
3-
import { DataTableDirective } from 'angular-datatables';
3+
import { DataTablesModule } from 'angular-datatables';
4+
import { NgxPaginationModule } from 'ngx-pagination';
45
import { Entry } from 'src/app/modules/shared/models';
56
import { SubstractDatePipe } from 'src/app/modules/shared/pipes/substract-date/substract-date.pipe';
67
import { getReportDataSource } from 'src/app/modules/time-clock/store/entry.selectors';
@@ -49,7 +50,7 @@ describe('Reports Page', () => {
4950
beforeEach(
5051
waitForAsync(() => {
5152
TestBed.configureTestingModule({
52-
imports: [],
53+
imports: [NgxPaginationModule, DataTablesModule],
5354
declarations: [TimeEntriesTableComponent, SubstractDatePipe],
5455
providers: [provideMockStore({ initialState: state })],
5556
}).compileComponents();
@@ -85,7 +86,9 @@ describe('Reports Page', () => {
8586
});
8687

8788
it('after the component is initialized it should initialize the table', () => {
89+
component.dtElement = null;
8890
spyOn(component.dtTrigger, 'next');
91+
8992
component.ngAfterViewInit();
9093

9194
expect(component.dtTrigger.next).toHaveBeenCalled();
@@ -137,11 +140,6 @@ describe('Reports Page', () => {
137140

138141
it('when the rerenderDataTable method is called and dtElement and dtInstance are defined, the destroy and next methods are called ',
139142
() => {
140-
component.dtElement = {
141-
dtInstance: {
142-
then : (dtInstance: DataTables.Api) => { dtInstance.destroy(); }
143-
}
144-
} as unknown as DataTableDirective;
145143
spyOn(component.dtElement.dtInstance, 'then');
146144
component.ngAfterViewInit();
147145
expect(component.dtElement.dtInstance.then).toHaveBeenCalled();

src/app/modules/shared/formatters/parse-date-time-offset/parse-date-time-offset.spec.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,21 +3,21 @@ import { ParseDateTimeOffset } from './parse-date-time-offset';
33
describe('ParseDateToUtcComponent', () => {
44

55
it('returns converted date when his offset is 300', () => {
6-
let parseTimeOffset = new ParseDateTimeOffset();
6+
const parseTimeOffset = new ParseDateTimeOffset();
77
const date = '2022-03-30T13:00:00Z';
8-
const timezone_offset = 300;
9-
const dateOffset:string = '08:00';
8+
const timezoneOffset = 300;
9+
const dateOffset = '08:00';
1010

11-
expect(parseTimeOffset.parseDateTimeOffset(date, timezone_offset)).toEqual(dateOffset);
11+
expect(parseTimeOffset.parseDateTimeOffset(date, timezoneOffset)).toEqual(dateOffset);
1212
});
1313

1414
it('returns converted date when his offset is 420', () => {
15-
let parseTimeOffset = new ParseDateTimeOffset();
15+
const parseTimeOffset = new ParseDateTimeOffset();
1616
const date = '2022-03-30T16:30:00Z';
17-
const timezone_offset = 420;
18-
const dateOffset:string = '09:30';
17+
const timezoneOffset = 420;
18+
const dateOffset = '09:30';
1919

20-
expect(parseTimeOffset.parseDateTimeOffset(date, timezone_offset)).toEqual(dateOffset);
20+
expect(parseTimeOffset.parseDateTimeOffset(date, timezoneOffset)).toEqual(dateOffset);
2121
});
2222

2323
});
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import * as moment from 'moment';
22

33
export class ParseDateTimeOffset {
4-
5-
parseDateTimeOffset(date:string, offset): string{
6-
return moment.utc(date).utcOffset(-1*offset).format("HH:mm");
4+
5+
parseDateTimeOffset(date: string, offset): string {
6+
return moment.utc(date).utcOffset(-1 * offset).format('HH:mm');
77
}
88
}

src/app/modules/time-entries/pages/time-entries.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export class TimeEntriesComponent implements OnInit, OnDestroy, AfterViewInit {
5353
isActiveEntryOverlapping = false;
5454
calendarView: CalendarView = CalendarView.Month;
5555
actualDate: Date;
56-
dateTimeOffset : ParseDateTimeOffset;
56+
dateTimeOffset: ParseDateTimeOffset;
5757
constructor(
5858
private store: Store<EntryState>,
5959
private toastrService: ToastrService,

0 commit comments

Comments
 (0)