fix: TTL-887 make changes according PR review

Author: Santiago220991

src/app/modules/time-clock/pages/time-clock.component.spec.ts

@@ -14,6 +14,7 @@ import { EntryFieldsComponent } from '../components/entry-fields/entry-fields.co
 import { ToastrService } from 'ngx-toastr';
 import { LoginService } from '../../login/services/login.service';
 import { SocialAuthService } from 'angularx-social-login';
+import { dispatch } from 'rxjs/internal/observable/pairs';
 
 describe('TimeClockComponent', () => {
   let component: TimeClockComponent;
@@ -152,12 +153,11 @@ describe('TimeClockComponent', () => {
     expect(store.dispatch).toHaveBeenCalledWith(new StopTimeEntryRunning('id'));
   });
 
-  it('clockOut set error Activity is required', () => {
+  it('clockOut doesnt execute stopEntry() if entryFormIsValidate() returns false', () => {
     spyOn(store, 'dispatch');
-    spyOn(injectedToastrService, 'error');
     spyOn(component.entryFieldsComponent, 'entryFormIsValidate').and.returnValue(false);
     component.clockOut();
 
-    expect(injectedToastrService.error).toHaveBeenCalled();
+    expect(store.dispatch).not.toHaveBeenCalled();
   });
 });

src/app/modules/time-clock/pages/time-clock.component.ts

@@ -40,8 +40,8 @@ export class TimeClockComponent implements OnInit, OnDestroy {
   ngOnInit(): void {
     if (this.isProduction) {
       this.username = this.azureAdB2CService.isLogin() ? this.azureAdB2CService.getName() : '';
-    }else{
-      this.loginService.isLogin().subscribe(isLogin => {
+    } else {
+      this.loginService.isLogin().subscribe((isLogin) => {
         this.username = isLogin ? this.loginService.getName() : '';
       });
     }
@@ -57,14 +57,11 @@ export class TimeClockComponent implements OnInit, OnDestroy {
   }
 
   reloadSummariesOnClockOut() {
-    this.clockOutSubscription = this.actionsSubject$.pipe(
-      filter((action) => (
-          action.type === EntryActionTypes.STOP_TIME_ENTRY_RUNNING_SUCCESS
-        )
-      )
-    ).subscribe( (action) => {
-      this.store.dispatch(new LoadEntriesSummary());
-    });
+    this.clockOutSubscription = this.actionsSubject$
+      .pipe(filter((action) => action.type === EntryActionTypes.STOP_TIME_ENTRY_RUNNING_SUCCESS))
+      .subscribe((action) => {
+        this.store.dispatch(new LoadEntriesSummary());
+      });
   }
 
   stopEntry() {
@@ -75,16 +72,11 @@ export class TimeClockComponent implements OnInit, OnDestroy {
   clockOut() {
     if (this.entryFieldsComponent.entryFormIsValidate()) {
       this.stopEntry();
-    } else {
-      this.entryFieldsComponent.entryForm.get('activity_id').markAsTouched();
     }
   }
 
   ngOnDestroy(): void {
     this.clockOutSubscription.unsubscribe();
     this.storeSubscription.unsubscribe();
   }
-
 }
-
-