fix: TT-178 Make URI clickable when possible

Author: wobravo

src/app/modules/reports/components/time-entries-table/time-entries-table.component.html

@@ -4,7 +4,7 @@
     datatable
     [dtTrigger]="dtTrigger"
     [dtOptions]="dtOptions"
-    *ngIf="reportDataSource$ | async as dataSource">
+    *ngIf="(reportDataSource$ | async) as dataSource">
     <thead class="thead-blue">
       <tr class="d-flex">
         <th class="hidden-col">ID</th>

src/app/modules/reports/components/time-entries-table/time-entries-table.component.spec.ts

@@ -89,19 +89,19 @@ describe('Reports Page', () => {
     });
 
     it('when the uri starts without http or https it should return false and not navigate or open a new tab', () => {
-      const uriExpected = timeEntry.uri;
+      const url = timeEntry.uri;
       spyOn(component, 'isURL').and.returnValue(false);
 
-      expect(component.openURLInNewTab(uriExpected)).toEqual('');
+      expect(component.openURLInNewTab(url)).toEqual('');
     });
 
     const params = [
-      {url: 'http://example.com', expected_value: true, with: 'with'},
-      {url: 'https://example.com', expected_value: true, with: 'with'},
-      {url: 'no-url-example', expected_value: false, with: 'without'}
+      {url: 'http://example.com', expected_value: true},
+      {url: 'https://example.com', expected_value: true},
+      {url: 'no-url-example', expected_value: false}
     ];
     params.map((param) => {
-      it(`when the url starts ${param.with} http or https it should return ${param.expected_value}`, () => {
+      it(`Given the url ${param.url}, the method isURL should return ${param.expected_value}`, () => {
 
       expect(component.isURL(param.url)).toEqual(param.expected_value);
       });

src/app/modules/reports/components/time-entries-table/time-entries-table.component.ts

@@ -1,5 +1,5 @@
 import { formatDate } from '@angular/common';
-import { AfterViewInit, Component, OnDestroy, OnInit, ViewChild, NgModule } from '@angular/core';
+import { AfterViewInit, Component, OnDestroy, OnInit, ViewChild} from '@angular/core';
 import { select, Store } from '@ngrx/store';
 import { DataTableDirective } from 'angular-datatables';
 import * as moment from 'moment';
@@ -30,7 +30,9 @@ export class TimeEntriesTableComponent implements OnInit, OnDestroy, AfterViewIn
         exportOptions: {
           format: {
             body: (data, row, column, node) => {
-              return column === 3 ? moment.duration(data).asHours().toFixed(4).slice(0, -1) : data;
+              return column === 3 ?
+              moment.duration(data).asHours().toFixed(4).slice(0, -1) :
+              data;
             },
           },
         },
@@ -42,7 +44,9 @@ export class TimeEntriesTableComponent implements OnInit, OnDestroy, AfterViewIn
         exportOptions: {
           format: {
             body: (data, row, column, node) => {
-              return column === 3 ? moment.duration(data).asHours().toFixed(4).slice(0, -1) : data;
+              return column === 3 ?
+              moment.duration(data).asHours().toFixed(4).slice(0, -1) :
+              data;
             },
           },
         },
@@ -92,6 +96,6 @@ export class TimeEntriesTableComponent implements OnInit, OnDestroy, AfterViewIn
 
   isURL(uri: string) {
     const regex = new RegExp('http*', 'g');
-    return regex.test(uri) ? true : false;
+    return regex.test(uri);
   }
 }