refactor: TTA-115 create unit test for function checkTypeError in status network service

Author: Abigail Cabascango

src/app/app.module.ts

@@ -100,7 +100,7 @@ import { FastDirective} from './modules/internet-connection-status/internet-conn
 import { SlowDirective} from './modules/internet-connection-status/internet-connection-directives/slow.directive';
 import { OfflineDirective} from './modules/internet-connection-status/internet-connection-directives/offline.directive';
 import { ConnectionDirective } from './modules/internet-connection-status/internet-connection-directives/connection.directive';
-
+import { ToastrService } from 'ngx-toastr';
 
 const maskConfig: Partial<IConfig> = {
   validation: false,
@@ -219,6 +219,7 @@ const maskConfig: Partial<IConfig> = {
     },
     DatePipe,
     CookieService,
+    ToastrService,
     {provide: Window, useValue: window}
   ],
   bootstrap: [AppComponent],

src/app/modules/shared/services/status-network.service.spec.ts

@@ -1,7 +1,7 @@
 import { TestBed } from '@angular/core/testing';
 import * as assert from 'assert';
 import { catchError, map, mergeMap } from 'rxjs/operators';
-
+import { IndividualConfig, ToastrService } from 'ngx-toastr';
 import { StatusNetworkService } from './status-network.service';
 
 export interface ErrorType {
@@ -11,14 +11,31 @@ export interface ErrorType {
 }
 describe('StatusNetworkService', () => {
   let service: StatusNetworkService;
-  const errorType: ErrorType = {error: catchError, message: 'javascript', isError: false};
+  const toastrServiceStub = {
+    error: (message?: string, title?: string, override?: Partial<IndividualConfig>) => { },
+    warning: (message?: string, title?: string, override?: Partial<IndividualConfig>) => { }
+  };
 
   beforeEach(() => {
-    TestBed.configureTestingModule({});
+    TestBed.configureTestingModule({
+      providers: [ToastrService, {
+        provide: ToastrService, useValue: toastrServiceStub
+      }]
+    });
     service = TestBed.inject(StatusNetworkService);
   });
 
+  fit('checkTypeError is error', () => {
+    const errorType: ErrorType = {error: catchError, message: 'javascript', isError: true};
+    spyOn(toastrServiceStub, 'error');
+    service.checkTypeError(errorType)
+    expect(toastrServiceStub.error).toHaveBeenCalled();
+  });
+
   fit('checkTypeError is warning', () => {
-    assert(service.checkTypeError(errorType) == 'is warning');
+    const errorType: ErrorType = {error: catchError, message: 'javascript', isError: false};
+    spyOn(toastrServiceStub, 'warning');
+    service.checkTypeError(errorType)
+    expect(toastrServiceStub.warning).toHaveBeenCalled();
   });
 });

src/app/modules/shared/services/status-network.service.ts

@@ -22,15 +22,12 @@ export class StatusNetworkService {
       if ((effectiveTypenetwork.effectiveType != '2g')){
         if(!isError){
           this.toastrService.warning(message);
-          return 'is warning';
         }
         if(isError){
-          const errorMessa =  error.error && error.error.message? error.error.message: 'There is an error with the server, your request have not be completed';
+          const errorMessa = error.error && error.error.message? error.error.message: 'There is an error with the server, your request have not be completed';
           this.toastrService.error(errorMessa);
-          return 'is error';
         }
       }
       this.toastrService.warning('Your request was not completed, your connection is slow');
-      return 'is warning';
   }
 }